Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix unused snapshots not triggering failure in CI" #129223

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 26, 2024

Reverts #128162

Comment by @jbouwh here: #128162 (comment)

This fix seems to cause a performance regression as a side effect.

E.g.: pytest -n auto tests/components/mqtt/

This takes 25.75 sec without this fix on my dev env. and 72.24 sec with.

When coverage is tested too, it gets worse: This takes 46.24 sec without this fix and 189.09 sec with.

@frenck frenck requested a review from a team as a code owner October 26, 2024 13:23
@jbouwh jbouwh added the bugfix label Oct 26, 2024
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frenck and @epenet 👍

@jbouwh jbouwh merged commit 35b7c30 into dev Oct 26, 2024
46 checks passed
@jbouwh jbouwh deleted the revert-128162-20241011-1431 branch October 26, 2024 14:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants