Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use voluptuous for time/date sensors #2799

Merged
merged 3 commits into from
Aug 16, 2016
Merged

Use voluptuous for time/date sensors #2799

merged 3 commits into from
Aug 16, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Aug 12, 2016

Description:

Related issue (if applicable): fixes 127528299

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: worldclock
    time_zone: America/New_York
    name: New York
  - platform: time_date
    display_options:
      - 'time'
      - 'date'
      - 'beat'

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices, web services, or a:

  • [] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • [] New dependencies have been added to the REQUIREMENTS variable (example).
  • [] New dependencies are only imported inside functions that use them (example).
  • [] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [] New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@fabaff fabaff mentioned this pull request Aug 12, 2016
DEFAULT_NAME = "Worldclock Sensor"
ICON = 'mdi:clock'
TIME_STR_FORMAT = "%H:%M"

PLATFORM_SCHEMA = vol.Schema({
vol.Required(CONF_PLATFORM): 'worldclock',
vol.Required(CONF_TIME_ZONE): cv.string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cv.time_zone 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@balloob
Copy link
Member

balloob commented Aug 16, 2016

Ok to merge when comments addressed 🐬

@fabaff fabaff merged commit dab5a78 into home-assistant:dev Aug 16, 2016
@fabaff fabaff deleted the voluptuous-sensors1 branch August 16, 2016 19:43
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants