Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use voluptuous for transport sensors #2867

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Use voluptuous for transport sensors #2867

merged 1 commit into from
Aug 19, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Aug 18, 2016

Description:

Related issue (if applicable): fixes 127528299

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices, web services, or a:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.


DEFAULT_NAME = 'REST Binary Sensor'
DEFAULT_METHOD = 'GET'

PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
vol.Required(CONF_RESOURCE): vol.Coerce(url),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

farcy v1.1

  • 45: F821 undefined name 'url'

@fabaff fabaff changed the title Voluptuous sensors6 Use voluptuous for transport sensors Aug 18, 2016
@fabaff fabaff mentioned this pull request Aug 18, 2016
@balloob
Copy link
Member

balloob commented Aug 19, 2016

Score! 🐬

@balloob balloob merged commit 0abc50e into home-assistant:dev Aug 19, 2016
@fabaff fabaff deleted the voluptuous-sensors6 branch August 19, 2016 07:52
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants