Add voluptuous to ecobee, speedtest.net, fast.com, actiontec, forecast.io #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Nothing you can do with actiontec. You replaced the new lines on each line, so each line actually did change. |
| # pylint: disable=unused-argument | ||
| def get_scanner(hass, config): | ||
| """Validate the configuration and return an Actiontec scanner.""" | ||
| if not validate_config(config, |
There was a problem hiding this comment.
Please remove the use of validate_config
There was a problem hiding this comment.
This is no longer needed. voluptuous is taking care that the required values are present.
|
Sorry, was offline while writing my comments. I didn't get the comments by @balloob. |
fabaff
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For the speedtest.net and fast.com I'm not sure if I did it right. I get this exception when values are out of range:
voluptuous.error.MultipleInvalid: value must be at most 23 @ data['hour'][0]Also I ran a sed command to remove carriage returns from actiontec.py and now it sees the whole file as different. I only added the PLATFORM_SCHEMA
Related issue (if applicable): fixes #2800