Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use voluptuous for Proximity #3293

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Use voluptuous for Proximity #3293

merged 1 commit into from
Oct 11, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Sep 9, 2016

Description:
Migration of the configuration check to voluptuous. The configuration style was aligned with other components,

Related issue (if applicable): fixes 127528299

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#1205

Example entry for configuration.yaml (if applicable):

proximity:
  home:
    ignored_zones:
      - twork
      - elschool
    devices:
      - device_tracker.nwaring_nickmobile
      - device_tracker.eleanorsiphone
      - device_tracker.tsiphone
    tolerance: 50
    unit_of_measurement: mi
  home3:
    devices:
      - device_tracker.tsiphone
    tolerance: 50
  work:
    devices:
      - device_tracker.elanorsiphone
    tolerance: 10

Would be nice if somebody could take a look at the changes and run a quick test. Thanks.

@fabaff fabaff mentioned this pull request Sep 9, 2016
@balloob
Copy link
Member

balloob commented Sep 10, 2016

Tests have to be updated to use bootstrap.setup_component to trigger the schema validation.

@balloob
Copy link
Member

balloob commented Sep 30, 2016

Looks like some test broke.

@fabaff
Copy link
Member Author

fabaff commented Oct 8, 2016

This became a breaking change.

@balloob balloob merged commit 7cf9ff8 into home-assistant:dev Oct 11, 2016
@happyleavesaoc
Copy link
Contributor

Confirming that this change works, FWIW.

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
@fabaff fabaff deleted the voluptuous-proximity branch April 12, 2017 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants