Use voluptuous for iTunes #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -39,23 +52,23 @@ def __init__(self, host, port): | |||
| def _base_url(self): | |||
| """Return the base url for endpoints.""" | |||
| if self.port: | |||
| return self.host + ":" + str(self.port) | |||
| return 'http://{}:{}'.format(self.host, self.port) | |||
There was a problem hiding this comment.
we should probably support an ssl: true configuration in case this is behind SSL.
I personally previously did use itunes-api behind an nginx proxy, though I had HA configured to talking to it over localhost get those extra milliseconds, heh. But regardless, people might be behind HTTPS.
It doesn't natively, but it could very well be behind an NGINX proxy* *my comments on this are on the commit. |
|
Support for SSL/TLS was added. This will need a test from a person who is running |
| response = requests.delete(url) | ||
| response = requests.get(url, timeout=DEFAULT_TIMEOUT) | ||
| elif method == 'POST': | ||
| response = requests.put(url, params, timeout=DEFAULT_TIMEOUT) |
|
It's compatible with the old code, so 🐬 |
|
👍 |
hartmms
pushed a commit
to hartmms/home-assistant
that referenced
this pull request
Sep 17, 2016
* Migrate to voluptuous * Add support for SSL/TLS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Migration of the configuration check to
voluptuous. This is a breaking change ashttp://will no longer be needed for thehost:configuration variable. Not sure ifitunes-apisupports SSL/TLS.Related issue (if applicable): fixes 127528299
Example entry for
configuration.yaml(if applicable):@maddox, would be nice if you could take a look at the changes and run a quick test. Thanks.