Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use voluptuous for Russound RNET #3689

Merged
merged 2 commits into from
Oct 9, 2016
Merged

Use voluptuous for Russound RNET #3689

merged 2 commits into from
Oct 9, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Oct 4, 2016

Description:
Migration of the configuration check to voluptuous.

Related issue (if applicable): fixes 127528299

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: russound_rnet
    host: 192.168.1.10
    port: 1337
    name: Russound
    zones:
      1:
        name: Main Bedroom
      2:
        name: Living Room
      3:
        name: Kitchen
      4:
        name: Bathroom
      5:
        name: Dining Room
      6:
        name: Guest Bedroom
    sources:
      - name: Sonos
      - name: Sky+

@mention-bot
Copy link

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @laf to be a potential reviewer.

@fabaff fabaff mentioned this pull request Oct 4, 2016
@laf
Copy link
Contributor

laf commented Oct 4, 2016

I'll give this a test at the weekend if that's ok?

vol.Required(CONF_NAME): cv.string,
vol.Required(CONF_PORT): cv.port,
vol.Required(CONF_ZONES): vol.Schema({cv.positive_int: ZONE_SCHEMA}),
vol.Required(CONF_SOURCES, default=[]):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is required, do not default it to an empty list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@laf
Copy link
Contributor

laf commented Oct 9, 2016

Sorry for the delay folks, tested and no issues. for me.

@fabaff fabaff merged commit dc95b28 into home-assistant:dev Oct 9, 2016
@fabaff fabaff deleted the voluptuous-russound branch October 9, 2016 14:40
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants