Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto from the fan speed modes for VeSync #40559

Merged
merged 5 commits into from
Sep 25, 2020

Conversation

TheGardenMonkey
Copy link
Contributor

@TheGardenMonkey TheGardenMonkey commented Sep 24, 2020

Breaking change

  • Remove the auto fan mode for the fan platform. The auto mode isn't supported by the entity model in Home Assistant and was initially added overlooking our entity model. Users that have automations or scripts targeting the vesync fan entity should review these and update as needed.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes Vesync fan speed #40552
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @markperdue, @webdjoe, mind taking a look at this pull request as its been labeled with an integration (vesync) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@TheGardenMonkey TheGardenMonkey changed the title Puts AUTO at the end of the FAN SPEED list Removes AUTO from the FAN SPEED list for VeSync Sep 24, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Removes AUTO from the FAN SPEED list for VeSync Remove auto from the fan speed modes for VeSync Sep 25, 2020
@MartinHjelmare
Copy link
Member

Please make a docs PR too and update the fan attributes example:
https://www.home-assistant.io/integrations/vesync/#fan-exposed-attributes

@TheGardenMonkey
Copy link
Contributor Author

Please make a docs PR too and update the fan attributes example:
https://www.home-assistant.io/integrations/vesync/#fan-exposed-attributes

Created PR: home-assistant/home-assistant.io#14607

@MartinHjelmare
Copy link
Member

Thanks!

@MartinHjelmare MartinHjelmare merged commit 318096b into home-assistant:dev Sep 25, 2020
@TheGardenMonkey TheGardenMonkey deleted the vesync-fan branch September 25, 2020 14:14
@jkempson
Copy link

I am unsure how I am now supposed to turn the fan to "auto" mode from within HA?

@MartinHjelmare
Copy link
Member

That's not possible currently without a custom service.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vesync fan speed
5 participants