-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TaHoma integration (base + Binary Sensor) #43966
Add TaHoma integration (base + Binary Sensor) #43966
Conversation
82bdd76
to
b4c6037
Compare
Why the new domain? If the old integration is broken, you can just replace it, right? |
See discussion at #43952 (comment). |
I am not sure what we all agreed on in the end in #43952. Should we change this PR to target Our reason for targeting Target branch change to 'rework-tahoma'. |
I would say; keep the domain as is. Another helpful thing for users; is migration. The username/password from an existing |
08b465c
to
03992d6
Compare
Done! This PR will now target the I will add back the YAML config support in a separate PR to keep this PR small, since we now target a feature branch. |
698479e
to
d93a410
Compare
Lately, I accidentally rebased on latest dev, but I forgot that the target is If this PR is reviewed / merged to the work branch, I will add all other (small) PR's, however we first need to have the base merged for that. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
21c1b1e
to
c4c28a9
Compare
Processed all feedback and all checks have passed. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Yeah, translations are needed to test the frontend, and this will be updated by our infrastructure and Lokalise. But we do allow committing the default English translation file for testing purposes and convenience. |
Ok, I will add the English one to this PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"manufacturer": manufacturer, | ||
"name": self.name, | ||
"model": model, | ||
"sw_version": self.device.controllable_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this device can set suggested_area
here in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We created it as a work item already on our custom component repo, iMicknl/ha-tahoma#392 :). However, it would require pulling the TaHoma area's first and that endpoint hasn't been implemented yet in our client.
Please link a docs PR in the PR description. Make a note in the docs PR that there will be multiple parent PRs in the core repo before the docs PR should be merged. Then we can merge here. |
@MartinHjelmare is it ok to add the docs for the final PR to update: |
Yeah, the idea is that we use a single docs PR for this work. |
Proposed change
Since #41267 is not easy to review, we (@vlebourl, @tetienne and me) will split the work done in https://github.com/imicknl/ha-tahoma in multiple small PR's. This PR includes some of the ground work for other platforms, but all non necessary code has been removed to keep it as small as possible.
Would be great to PR this to a feature branch, instead of dev, since I would like to have all platforms (especially cover) included in a core release.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: