-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vesync to use new fan entity model #45585
Update vesync to use new fan entity model #45585
Conversation
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
a27a496
to
991fe99
Compare
Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as its been labeled with an integration ( |
FAN_MODE_AUTO = "auto" | ||
FAN_MODE_SLEEP = "sleep" | ||
|
||
PRESET_MODES = [FAN_MODE_AUTO, FAN_MODE_SLEEP] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a FAN_MODE_NONE
so that users can disable a preset mode ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to think about how I would use it.
I'm thinking I would use it like:
from Auto
-> Medium Speed
or Auto
-> Off
and wouldn't do Auto
-> None
-> Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some testing with the frontend PR to make sure that is actually how I would use it with the demo fan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ordered a LV-PUR131S
for testing and will adjust later if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ordered a
LV-PUR131S
for testing and will adjust later if needed
I am available to test this when you feel it is ready as well. I have 3 of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could give the latest dev a try along with latest frontend with home-assistant/frontend#8216 and provide feedback, that would be most excellent.
Requires #45407
Proposed change
Update vesync to use new fan entity model
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: