Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vesync to use new fan entity model #45585

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 26, 2021

Requires #45407

Proposed change

Update vesync to use new fan entity model

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@bdraco bdraco force-pushed the vesync_fan_speed_percentage branch from a27a496 to 991fe99 Compare January 28, 2021 04:35
@bdraco bdraco marked this pull request as ready for review January 28, 2021 04:35
@probot-home-assistant
Copy link

Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as its been labeled with an integration (vesync) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

FAN_MODE_AUTO = "auto"
FAN_MODE_SLEEP = "sleep"

PRESET_MODES = [FAN_MODE_AUTO, FAN_MODE_SLEEP]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a FAN_MODE_NONE so that users can disable a preset mode ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to think about how I would use it.

I'm thinking I would use it like:

from Auto -> Medium Speed or Auto -> Off and wouldn't do Auto -> None -> Medium

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some testing with the frontend PR to make sure that is actually how I would use it with the demo fan.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2Uetqxcxe

If the device still reports the fan level in Auto mode, maybe it makes sense to add Manual (suggested as None).

If the device doesn't report the fan level in auto mode then it probably is fine as is.

Copy link
Member Author

@bdraco bdraco Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ordered a LV-PUR131S for testing and will adjust later if needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ordered a LV-PUR131S for testing and will adjust later if needed

I am available to test this when you feel it is ready as well. I have 3 of these.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could give the latest dev a try along with latest frontend with home-assistant/frontend#8216 and provide feedback, that would be most excellent.

@balloob balloob merged commit fdcf1fc into home-assistant:dev Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants