Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alarm control panel to Overkiz integration #67164

Merged
merged 9 commits into from
Mar 28, 2022

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Feb 24, 2022

Proposed change

Adds support for the four alarm control panel implementations that we are aware of.

Previously in our custom component, we had four different classes that implemented all devices, however for this PR I tried to use entity descriptions. I'm not sure which version I like most, but this is more aligned to core perhaps.

(marked as draft, since a mypy issue needs to be fixed)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cleaner to separate the command (it's always a string) from the arguments (which are optional and can be numerous)

homeassistant/components/overkiz/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/overkiz/alarm_control_panel.py Outdated Show resolved Hide resolved
homeassistant/components/overkiz/alarm_control_panel.py Outdated Show resolved Hide resolved
@iMicknl iMicknl marked this pull request as draft March 5, 2022 10:41
@iMicknl iMicknl force-pushed the overkiz/alarm_control_panel branch from a95134e to 225ed48 Compare March 28, 2022 15:03
@iMicknl iMicknl marked this pull request as ready for review March 28, 2022 15:33
@balloob balloob merged commit d0e5e51 into home-assistant:dev Mar 28, 2022
@iMicknl iMicknl deleted the overkiz/alarm_control_panel branch March 28, 2022 22:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overkiz (by Somfy) - Alarm detected but not working
4 participants