-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alarm control panel to Overkiz integration #67164
Add alarm control panel to Overkiz integration #67164
Conversation
Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be cleaner to separate the command (it's always a string) from the arguments (which are optional and can be numerous)
a95134e
to
225ed48
Compare
Proposed change
Adds support for the four alarm control panel implementations that we are aware of.
Previously in our custom component, we had four different classes that implemented all devices, however for this PR I tried to use entity descriptions. I'm not sure which version I like most, but this is more aligned to core perhaps.
(marked as draft, since a mypy issue needs to be fixed)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: