Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wink Aros Fixes #6726

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Wink Aros Fixes #6726

merged 1 commit into from
Mar 24, 2017

Conversation

geekofweek
Copy link
Contributor

@geekofweek geekofweek commented Mar 20, 2017

Description:

Wink Aros only supports 3 Fan Modes:

  • Low
  • Medium
  • High

Fan Mode had a Typo and wasn't represented in the UI

Tested Locally with Wink Aros Unit

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Wink Aros only supports 3 Fan Modes:

Low
Medium
High

Fan Mode had a Typo and wasn't represented in the UI
@mention-bot
Copy link

@geekofweek, thanks for your PR! By analyzing the history of the files in this pull request, we identified @w1ll1am23 to be a potential reviewer.

@homeassistant
Copy link
Contributor

Hi @geekofweek,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@w1ll1am23
Copy link
Contributor

Looks good to me, didn't know anyone that had one of these so it wasn't ever really tested. Glad to see someone is getting to use it!

@w1ll1am23 w1ll1am23 merged commit 06d3889 into home-assistant:dev Mar 24, 2017
@geekofweek
Copy link
Contributor Author

I'm probably one of the few people that have one. It's not my primary unit so it wasn't much of a big deal but I just started writing some automations around it and testing it before I'll start using it over the summer.

@geekofweek geekofweek deleted the patch-1 branch March 25, 2017 00:10
@fabaff fabaff mentioned this pull request Apr 6, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jun 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants