Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin click to fix typer issue #68808

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Pin click to fix typer issue #68808

merged 1 commit into from
Mar 28, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Mar 28, 2022

Proposed change

Pin click to fix typer issue: fastapi/typer#375, used by pyunifiprotect

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added bugfix core small-pr PRs with less than 30 lines. labels Mar 28, 2022
@cdce8p cdce8p merged commit f067aa6 into home-assistant:dev Mar 28, 2022
@epenet epenet deleted the pin-click branch March 29, 2022 04:45
@epenet epenet mentioned this pull request Mar 29, 2022
@MartinHjelmare MartinHjelmare added this to the 2022.3.8 milestone Mar 29, 2022
frenck pushed a commit that referenced this pull request Mar 29, 2022
Co-authored-by: epenet <epenet@users.noreply.github.com>

# Required for compatibility with typer, used by pyunifiprotect integration
# https://github.com/tiangolo/typer/pull/375
click<=8.0.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? What does the " do after the version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - it shouldn't be there!

I'm surprised it was accepted by PIP, and didn't get picked up by hassfest...

@epenet epenet mentioned this pull request Mar 29, 2022
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants