light.yeelight: catch i/o related exceptions from the backend lib #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rytilahti, thanks for your PR! By analyzing the history of the files in this pull request, we identified @HydrelioxGitHub, @jjensn and @BillyNate to be potential reviewers. |
houndci-bot
reviewed
Apr 5, 2017
| self._bulb.start_flow(flow) | ||
| try: | ||
| self._bulb.start_flow(flow) | ||
| except yeelight.BulbException as ex: |
| @@ -255,7 +255,8 @@ def set_default(self) -> None: | |||
| def set_flash(self, flash) -> None: | |||
| """Activate flash.""" | |||
| if flash: | |||
| from yeelight import RGBTransition, SleepTransition, Flow | |||
| from yeelight import (RGBTransition, SleepTransition, Flow, | |||
There was a problem hiding this comment.
'yeelight.BulbException' imported but unused
There was a problem hiding this comment.
Fixed by forced push, it was used in the prefixed form below in the code.
Fixes/mitigates problems with home-assistant#5949 and home-assistant#6624
rytilahti
force-pushed
the
yeelight_catch_music_mode_exception
branch
from
f717468 to
8c973ea
Compare
|
Cherry-picked into the 0.42 branch |
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes/mitigates problems with #5949 and #6624
Related issue (if applicable): fixes #5949 #6624
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.