Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded amcrest to 1.1.8 #6990

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

tchellomello
Copy link
Contributor

Description:

  • Upgraded Amcrest module to version 1.1.8
  • Fixed traceback when reporting the used storage percentage.
Apr 08 14:26:32 ha hass[4466]:   File "/opt/srv/homeassistant/.virtualenvs/hass_venv/lib/python3.5/site-packages/homeassistant/helpers/entity_component.py", line 189, in async_add_entity
Apr 08 14:26:32 ha hass[4466]:     yield from self.hass.loop.run_in_executor(None, entity.update)
Apr 08 14:26:32 ha hass[4466]:   File "/usr/lib64/python3.5/asyncio/futures.py", line 380, in __iter__
Apr 08 14:26:32 ha hass[4466]:     yield self  # This tells Task to wait for completion.
Apr 08 14:26:32 ha hass[4466]:   File "/usr/lib64/python3.5/asyncio/tasks.py", line 304, in _wakeup
Apr 08 14:26:32 ha hass[4466]:     future.result()
Apr 08 14:26:32 ha hass[4466]:   File "/usr/lib64/python3.5/asyncio/futures.py", line 293, in result
Apr 08 14:26:32 ha hass[4466]:     raise self._exception
Apr 08 14:26:32 ha hass[4466]:   File "/usr/lib64/python3.5/concurrent/futures/thread.py", line 55, in run
Apr 08 14:26:32 ha hass[4466]:     result = self.fn(*self.args, **self.kwargs)
Apr 08 14:26:32 ha hass[4466]:   File "/opt/srv/homeassistant/.virtualenvs/hass_venv/lib/python3.5/site-packages/homeassistant/components/sensor/amcrest.py", line 149, in update
Apr 08 14:26:32 ha hass[4466]:     self._state = self._camera.percent(sd_used[0], sd_total[0])
Apr 08 14:26:32 ha hass[4466]: AttributeError: 'Http' object has no attribute 'percent'

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Fixed traceback when calculating SD card percent storage

   self._state = self._camera.percent(sd_used[0], sd_total[0])
AttributeError: 'Http' object has no attribute 'percent'
@mention-bot
Copy link

@tchellomello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @rmkraus to be potential reviewers.

@balloob balloob added this to the 0.42 milestone Apr 8, 2017
@balloob balloob merged commit c5d8949 into home-assistant:dev Apr 8, 2017
balloob pushed a commit that referenced this pull request Apr 8, 2017
Fixed traceback when calculating SD card percent storage

   self._state = self._camera.percent(sd_used[0], sd_total[0])
AttributeError: 'Http' object has no attribute 'percent'
@fabaff fabaff mentioned this pull request Apr 8, 2017
@tchellomello tchellomello deleted the amcrest_sdcard_percent branch April 9, 2017 03:30
@balloob balloob mentioned this pull request Apr 21, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants