-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Overkiz AtlanticPassAPCDHW #78665
Add Overkiz AtlanticPassAPCDHW #78665
Conversation
Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Small item.
homeassistant/components/overkiz/water_heater_entities/atlantic_pass_apc_dhw.py
Outdated
Show resolved
Hide resolved
Undraft this PR in favor of creating another PR #79576 for async_execute_commands |
@bachya I don't know when you write "still in progress?", but no, I think this PR is ready for merging if reviewers are ok with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick comments to get you started. It is hard to review since codecov is adding comments on every line, so not very readable currently.
By the way, you may also join our Discord where all developers are if you are looking for some guidance / brainstorm sometimes.
homeassistant/components/overkiz/water_heater_entities/atlantic_pass_apc_dhw.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/water_heater_entities/atlantic_pass_apc_dhw.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/water_heater_entities/atlantic_pass_apc_dhw.py
Outdated
Show resolved
Hide resolved
Because I'm adding a new type of entity (water heater), Should I do a PR for the documentation to update this file: And if I should do it, when should I do it? And in this documentation PR, should I also update the Somfy integration as well? |
Let me get corrected if I'm wrong, but I believe you do have to update the doc concurrently and add the link to the PR in the |
Yes, I've done the PR in the |
Co-authored-by: Mick Vleeshouwer <mick@imick.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments otherwise looks good !
homeassistant/components/overkiz/water_heater_entities/atlantic_pass_apc_dhw.py
Outdated
Show resolved
Hide resolved
homeassistant/components/overkiz/water_heater_entities/atlantic_pass_apc_dhw.py
Show resolved
Hide resolved
homeassistant/components/overkiz/water_heater_entities/atlantic_pass_apc_dhw.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure this PR contains the latest ha-tahoma feature/fix
…c_pass_apc_dhw.py Co-authored-by: Quentame <polletquentin74@me.com>
…c_pass_apc_dhw.py Co-authored-by: Quentame <polletquentin74@me.com>
@Quentame As far as I know, this very specific entity was not supported in ha-tahoma. When this PR is merged and another one in pyoverkiz, I'm willing to rewrite supported water heater device in ha-tahoma here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job !
Thanks 🎉
@nyroDev Can you explain what is a As it will be used for the release notes, it will be more understandable for everyone. |
Breaking change
Proposed change
Implement Overkiz AtlanticPassAPCDHW, a Water Heater entity provided by Atlantic.
This entity is generally attached to an Atlantic heat pump.
Type of change
Additional information
Tested on my water heater, change of operation mode is working correctly.
I also added the async_execute_commands in the Overkiz executor in order to be able to execute multiple commands at once.
I did it because the regular web interface of Somfy do that.
I already addad a pull request #78659 who add the exact same multiple commands
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests:
Fixes #80375