-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade huawei-lte-api to 1.6.11 #85669
Conversation
We need to deal with the issues solved in e690db9 (which this one brings back) some different way.
Hey there @fphammerle, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @scop! 👍
About the issue you described, should this be fixed in the huawei-lte-api or inside the integration itself? In any case, I think we can merge this now. |
Thanks! I think the mentioned issue should be fixed with us. I've a WIP branch towards that, will submit a MR soonish once I get some more things ironed out. |
Ohh, should this go to the point release or rather wait for the next one (alongside the one this was spun out off)? |
Based on the number of issue reports we've received, I'd say at least this would be good to have in a point release. The other I'll rework later this evening, no objections if that goes in in one as well. I think it's a less severe one though. |
Proposed change
We need to deal with the issues solved in
e690db9 , #81751 (which this one brings back) some different way. They're less grave than the others it introduced.
Split up from #85572 in case we want to see this through separately first. Will rework that one if we do.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: