Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade huawei-lte-api to 1.6.11 #85669

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Upgrade huawei-lte-api to 1.6.11 #85669

merged 1 commit into from
Jan 11, 2023

Conversation

scop
Copy link
Member

@scop scop commented Jan 11, 2023

Proposed change

We need to deal with the issues solved in
e690db9 , #81751 (which this one brings back) some different way. They're less grave than the others it introduced.

Split up from #85572 in case we want to see this through separately first. Will rework that one if we do.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

We need to deal with the issues solved in
e690db9 (which this one brings back)
some different way.
@home-assistant
Copy link

Hey there @fphammerle, mind taking a look at this pull request as it has been labeled with an integration (huawei_lte) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of huawei_lte can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign huawei_lte Removes the current integration label and assignees on the issue, add the integration domain after the command.

@scop scop mentioned this pull request Jan 11, 2023
19 tasks
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @scop! 👍

@rytilahti
Copy link
Member

rytilahti commented Jan 11, 2023

About the issue you described, should this be fixed in the huawei-lte-api or inside the integration itself? In any case, I think we can merge this now.

@rytilahti rytilahti merged commit ccd7f09 into dev Jan 11, 2023
@rytilahti rytilahti deleted the scop-huawei-lte-api-1611 branch January 11, 2023 16:44
@scop
Copy link
Member Author

scop commented Jan 11, 2023

Thanks! I think the mentioned issue should be fixed with us. I've a WIP branch towards that, will submit a MR soonish once I get some more things ironed out.

@rytilahti rytilahti added this to the 2023.1.4 milestone Jan 11, 2023
@rytilahti
Copy link
Member

Ohh, should this go to the point release or rather wait for the next one (alongside the one this was spun out off)?

@scop
Copy link
Member Author

scop commented Jan 11, 2023

Based on the number of issue reports we've received, I'd say at least this would be good to have in a point release.

The other I'll rework later this evening, no objections if that goes in in one as well. I think it's a less severe one though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An unknown error has occurred on the device
3 participants