Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure humidity is still exported to HomeKit when it is read-only #87051

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 31, 2023

Proposed change

We would only send humidity to HomeKit if the device supported changing the humidity. We should always send it if the device has a valid humidity value.

I had a device that had the issue so this one was super easy to test the fix:

before
Screenshot 2023-01-31 at 5 08 10 PM

after
Screenshot 2023-01-31 at 5 23 41 PM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

We would only send humidity to HomeKit if the device supported
changing the humidity
@bdraco bdraco marked this pull request as ready for review January 31, 2023 22:54
@bdraco bdraco changed the title Ensure humidity is still exported to HomeKit when is cannot be set Ensure humidity is still exported to HomeKit when is read-only Jan 31, 2023
@bdraco bdraco changed the title Ensure humidity is still exported to HomeKit when is read-only Ensure humidity is still exported to HomeKit when it is read-only Jan 31, 2023
@balloob balloob merged commit faf79d0 into home-assistant:dev Feb 1, 2023
balloob pushed a commit that referenced this pull request Feb 1, 2023
…7051)

* Ensure humidity is still exported to HomeKit when is cannot be set

We would only send humidity to HomeKit if the device supported
changing the humidity

* remove unrelated changes
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HomeKit humidity value blank
2 participants