Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT-BR] improving intents #2238

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Conversation

gustvao
Copy link
Contributor

@gustvao gustvao commented Jun 18, 2024

small improvements for better intent UX with pt-br

Summary by CodeRabbit

  • New Features
    • Expanded vocabulary and added synonyms for actions like turning off, changing, and setting in Portuguese to improve command flexibility.
    • Updated intent expressions to include variations like "deixa pra lá" for smoother user interaction.
    • Enhanced sentence structures in Home Assistant to accept more flexible command inputs, particularly for setting positions, adjusting brightness, changing colors, and controlling lights.
    • Improved volume adjustment commands by adding "pra" as an alternative to "para."
    • Allowed both "para" and "pra" for vacuum return-to-base commands for better user accommodation.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gustvao

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft June 18, 2024 02:27
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link

coderabbitai bot commented Jun 18, 2024

Walkthrough

The overall changes enhance the flexibility and usability of voice commands for various actions in Portuguese for the Home Assistant project. This includes expanding the vocabulary for actions, refining sentence structures, and adding synonyms to accommodate user preferences and common variations in spoken language. These updates help improve the interpretation of commands related to turning off devices, setting positions, adjusting brightness, changing colors, setting volume, and controlling vacuum cleaners.

Changes

File Path Change Summary
sentences/pt-br/_common.yaml Expanded vocabulary for actions like turning off, changing, and setting.
sentences/pt-br/.../homeassistant_HassNevermind.yaml Updated expressions for the "deixa para lá" intent to include the variation "deixa pra lá".
sentences/pt-br/.../homeassistant_HassSetPosition.yaml Altered sentence structure for the HassSetPosition intent to allow more command variations.
sentences/pt-br/.../light_HassLightSet.yaml Refined language for commands related to adjusting brightness and changing light colors.
sentences/pt-br/.../media_player_HassSetVolume.yaml Added "pra" as an alternative to "para" for specifying volume adjustments in the HassSetVolume intent.
sentences/pt-br/.../vacuum_HassVacuumReturnToBase.yaml Allowed "pra" as an option in addition to "para" for returning a vacuum cleaner to its base.

Sequence Diagram(s)

Not applicable


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gustvao gustvao marked this pull request as ready for review June 18, 2024 02:28
@gustvao gustvao changed the title improving intents for pt-br [PT-BR] improving intents Jun 18, 2024
@luyzfernando08 luyzfernando08 merged commit dae1019 into home-assistant:main Jun 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants