Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES] Updating Spanish translations to 2024.6.21 #2245

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

davefx
Copy link
Contributor

@davefx davefx commented Jun 24, 2024

Spanish translations updated to version 2024.6.21.
Also, #2203 has been fixed and a test case has been added

Summary by CodeRabbit

  • New Features

    • Introduced Spanish language support for various timer-related intents in Home Assistant (e.g., start, pause, resume, cancel, and status updates).
    • Expanded media control functionality in Spanish, including pausing, resuming, and skipping tracks in different areas.
    • Enhanced the ability to query the state of cover devices in Spanish.
  • Tests

    • Added comprehensive test cases in Spanish to cover newly introduced timer and media control intents, ensuring accurate responses in Home Assistant.

Copy link

coderabbitai bot commented Jun 24, 2024

Walkthrough

Walkthrough

The changes primarily introduce Spanish language support for various Home Assistant intents related to timers, covers, media playback, and volume control. Additionally, the updates include new test cases to validate these functionalities and adjustments to error messages and entity definitions to accommodate these new features in the Spanish language context.

Changes

File(s) Change Summary
.../responses/es/HassCancelTimer.yaml Introduced Spanish response for HassCancelTimer intent: "Temporizador cancelado".
.../responses/es/HassDecreaseTimer.yaml Added Spanish response for HassDecreaseTimer intent: "Temporizador actualizado".
.../responses/es/HassIncreaseTimer.yaml Added Spanish response for HassIncreaseTimer intent: "Temporizador actualizado".
.../responses/es/HassPauseTimer.yaml Introduced Spanish response for HassPauseTimer: "Temporizador en pausa".
.../responses/es/HassStartTimer.yaml Added Spanish support for HassStartTimer with default and command responses.
.../responses/es/HassTimerStatus.yaml Added Spanish responses for HassTimerStatus, detailing timer states, next timer, and remaining time.
.../responses/es/HassUnpauseTimer.yaml Introduced Spanish response for HassUnpauseTimer: "Continuando temporizador".
.../sentences/es/_common.yaml Added error messages, expansion rules for commands, and timer-related command structures in Spanish.
.../sentences/es/cover_HassGetState.yaml Updated to allow flexible queries about covers, specifying <area> and <planta> in various Spanish sentence structures.
.../sentences/es/homeassistant_HassTurnOn.yaml Added new test case for turning on a lamp with the HassTurnOn intent in Spanish.
.../sentences/es/homeassistant_HassUnpauseTimer.yaml Introduced test cases for HassUnpauseTimer intent, covering scenarios like resuming a timer, specifying a duration, and continuing a timer in a specific area.
.../sentences/es/media_player_HassMediaNext.yaml Added variations for HassMediaNext intent, including different devices and locations for skipping tracks.
.../sentences/es/media_player_HassPauseTimer.yaml Added new intents for pausing media playback in different areas like "Salón".
.../tests/es/_fixtures.yaml Updated semantic structure for room areas, entity definitions, and timers, including renaming area identifiers and adding new timer configurations.
.../tests/es/cover_HassGetState.yaml Added new test cases for querying the state of cover devices in different areas and floors in Spanish.
.../tests/es/homeassistant_HassUnpauseTimer.yaml Introduced test cases for HassUnpauseTimer intent in Spanish, covering various resumption scenarios.
.../tests/es/media_player_HassMediaNext.yaml Expanded test cases for HassMediaNext intent to include skipping tracks on different devices and locations.
.../tests/es/media_player_HassMediaPause.yaml Added intents and responses for pausing media playback in areas like "Salón".
.../tests/es/media_player_HassMediaUnpause.yaml Added sentences and intents for HassMediaUnpause, resuming media playback in the living room with consistent responses.
.../tests/es/media_player_HassSetVolume.yaml Expanded commands for setting volume to 90%, including various phrases and contexts for adjusting volume levels.

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 891aa0f and 08d31d8.

Files selected for processing (35)
  • responses/es/HassCancelTimer.yaml (1 hunks)
  • responses/es/HassDecreaseTimer.yaml (1 hunks)
  • responses/es/HassIncreaseTimer.yaml (1 hunks)
  • responses/es/HassPauseTimer.yaml (1 hunks)
  • responses/es/HassStartTimer.yaml (1 hunks)
  • responses/es/HassTimerStatus.yaml (1 hunks)
  • responses/es/HassUnpauseTimer.yaml (1 hunks)
  • sentences/es/_common.yaml (4 hunks)
  • sentences/es/cover_HassGetState.yaml (1 hunks)
  • sentences/es/homeassistant_HassCancelTimer.yaml (1 hunks)
  • sentences/es/homeassistant_HassDecreaseTimer.yaml (1 hunks)
  • sentences/es/homeassistant_HassIncreaseTimer.yaml (1 hunks)
  • sentences/es/homeassistant_HassPauseTimer.yaml (1 hunks)
  • sentences/es/homeassistant_HassStartTimer.yaml (1 hunks)
  • sentences/es/homeassistant_HassTimerStatus.yaml (1 hunks)
  • sentences/es/homeassistant_HassUnpauseTimer.yaml (1 hunks)
  • sentences/es/light_HassTurnOn.yaml (1 hunks)
  • sentences/es/media_player_HassMediaNext.yaml (1 hunks)
  • sentences/es/media_player_HassMediaPause.yaml (1 hunks)
  • sentences/es/media_player_HassMediaUnpause.yaml (1 hunks)
  • sentences/es/media_player_HassSetVolume.yaml (1 hunks)
  • tests/es/_fixtures.yaml (13 hunks)
  • tests/es/cover_HassGetState.yaml (4 hunks)
  • tests/es/homeassistant_HassCancelTimer.yaml (1 hunks)
  • tests/es/homeassistant_HassDecreaseTimer.yaml (1 hunks)
  • tests/es/homeassistant_HassIncreaseTimer.yaml (1 hunks)
  • tests/es/homeassistant_HassPauseTimer.yaml (1 hunks)
  • tests/es/homeassistant_HassStartTimer.yaml (1 hunks)
  • tests/es/homeassistant_HassTimerStatus.yaml (1 hunks)
  • tests/es/homeassistant_HassTurnOn.yaml (1 hunks)
  • tests/es/homeassistant_HassUnpauseTimer.yaml (1 hunks)
  • tests/es/media_player_HassMediaNext.yaml (1 hunks)
  • tests/es/media_player_HassMediaPause.yaml (1 hunks)
  • tests/es/media_player_HassMediaUnpause.yaml (1 hunks)
  • tests/es/media_player_HassSetVolume.yaml (1 hunks)
Additional context used
yamllint
responses/es/HassTimerStatus.yaml

[error] 47-47: trailing spaces (trailing-spaces)


[error] 68-68: trailing spaces (trailing-spaces)

Additional comments not posted (36)
responses/es/HassPauseTimer.yaml (1)

1-6: Spanish translation for HassPauseTimer intent looks correct.

The YAML structure is correct, and the translation for "Temporizador en pausa" aligns with the intent of pausing a timer. This is a straightforward addition that seems to meet the requirements of the PR.

responses/es/HassCancelTimer.yaml (1)

1-6: Spanish translation for HassCancelTimer intent looks correct.

The YAML structure is properly maintained, and the translation "Temporizador cancelado" appropriately conveys the cancellation of a timer. This addition appears to be correct and useful for Spanish-speaking users.

responses/es/HassUnpauseTimer.yaml (1)

1-6: Spanish translation for HassUnpauseTimer intent looks correct.

The YAML structure is correct, and the translation "Continuando temporizador" accurately reflects the intent of unpausing a timer. This should enhance the user experience for Spanish speakers by providing clear and localized responses.
[APROVED]

responses/es/HassDecreaseTimer.yaml (1)

1-6: Spanish translation for HassDecreaseTimer intent looks correct.

The YAML structure is properly formatted, and the translation "Temporizador actualizado" is appropriate for the intent of decreasing a timer's duration. This translation should be clear for Spanish-speaking users.

responses/es/HassIncreaseTimer.yaml (1)

1-6: Spanish translation for HassIncreaseTimer looks good.

The YAML structure is correct, and the Spanish translation for the "increase timer" intent is appropriately set.

responses/es/HassStartTimer.yaml (1)

1-7: Spanish translations for HassStartTimer are correctly implemented.

The YAML structure is correct, and the Spanish translations for starting a timer are appropriately set with both a default response and a command acknowledgment.

sentences/es/homeassistant_HassPauseTimer.yaml (1)

1-10: Enhanced flexibility in pausing timers with new Spanish sentences.

The YAML structure is correct, and the added sentences provide various ways for users to interact with the timer pausing functionality in Spanish, improving usability.

sentences/es/homeassistant_HassUnpauseTimer.yaml (1)

1-10: Enhanced flexibility in unpausing timers with new Spanish sentences.

The YAML structure is correct, and the added sentences provide various ways for users to interact with the timer unpausing functionality in Spanish, improving usability.

sentences/es/homeassistant_HassCancelTimer.yaml (1)

1-10: Approved the new intent definitions.

The sentences are well structured and cover a variety of ways to cancel a timer, including specifying the timer name and area. This should provide good coverage for natural language processing.

sentences/es/media_player_HassMediaPause.yaml (1)

6-16: Approved the intent definitions for media pause.

The sentences and context requirements are correctly defined, ensuring that the pause command is properly contextualized within the media player domain and specific areas.

sentences/es/media_player_HassMediaUnpause.yaml (1)

6-16: Approved the intent definitions for media unpause.

The sentences and context requirements are correctly defined, ensuring that the unpause command is properly contextualized within the media player domain and specific areas.

tests/es/media_player_HassMediaPause.yaml (1)

10-29: Approved the test cases for media pause.

The test cases are well-structured and cover a variety of scenarios, ensuring that the pause functionality is thoroughly tested across different contexts and areas.

tests/es/media_player_HassMediaUnpause.yaml (3)

Line range hint 1-9: Review of initial test case setup for HassMediaUnpause

The initial test setup looks correct and adheres to the intent structure expected by Home Assistant. The response "Continuando reproducción" is consistent with the intent to unpause media playback, which is clearly defined.


10-18: Review of test case involving area context

The test case is well-structured and introduces an area-specific context, which is "Salón". This allows for more precise control and testing of media playback features in specific areas, enhancing the functionality of the Home Assistant in multi-room setups. The response is consistent and appropriate for the specified intent and context.


19-29: Review of expanded test case with multiple sentences

This block provides multiple ways to activate the intent, which is excellent for ensuring robustness in voice control scenarios. The inclusion of varied phrasing ("seguir con la música en el salón", "continúa en el salón la reproducción", "reactivar el reproductor del salón") enhances the natural language processing capabilities. The response remains consistent, ensuring user expectations are met.

sentences/es/homeassistant_HassStartTimer.yaml (1)

1-16: Comprehensive review of sentence structures for starting timers

The sentences provided cover a wide range of natural language commands to start timers, which is crucial for user-friendly voice interactions. The use of optional elements and placeholders (e.g., <timer_set>, <timer_duration>, {timer_name:name}) allows for flexible and descriptive timer setups. The context requirement of area with slot: false is appropriate, ensuring that the timer setup does not unnecessarily restrict to specific areas unless explicitly stated. This setup supports a robust implementation of timer functionalities.

sentences/es/media_player_HassMediaNext.yaml (1)

Line range hint 1-18: Review of sentence structures for media track control

The sentences provided facilitate a variety of commands to skip to the next media track, which is essential for a seamless media control experience. The inclusion of placeholders and optional elements (e.g., <pista>, <name>, <area>) offers flexibility in command usage. The context requirement for area with slot: true is particularly noteworthy, as it allows for area-specific media control, enhancing the user experience in multi-room setups. This setup supports a robust implementation of media control functionalities.

tests/es/homeassistant_HassTurnOn.yaml (1)

1-9: Review of test case for turning on a bedside lamp

The test case is well-structured and specifically targets the scenario of turning on a bedside lamp. The sentence "enciende lámpara de la mesilla" directly corresponds to the intent and the provided response is clear and appropriate. This test case effectively verifies the functionality of voice commands for device control.

sentences/es/media_player_HassSetVolume.yaml (1)

6-20: Enhanced flexibility in volume control commands.

The addition of various sentence structures to set volume, including specifying areas, enhances user interaction by allowing more natural language commands. Ensure these changes integrate well with the existing system and other language configurations.

Verification successful

Enhanced flexibility in volume control commands.

The addition of various sentence structures to set volume, including specifying areas, enhances user interaction by allowing more natural language commands. The integration check shows consistent patterns across different language configurations, confirming that the changes are aligned with existing intents.

  • The changes in sentences/es/media_player_HassSetVolume.yaml are consistent with other language configurations.
  • No integration issues were found.
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Check for integration issues with other language configurations.

# Test: Search for similar changes in other language files to ensure consistency.
fd 'media_player_HassSetVolume.yaml' --exec rg 'volumen'

Length of output: 1432



Script:

#!/bin/bash
# Description: Check for integration issues with other language configurations.

# Test: Search for similar changes in other language files to ensure consistency.
fd 'media_player_HassSetVolume.yaml' --exec rg 'volumen'
fd 'media_player_HassSetVolume.yaml' --exec rg 'volume'

Length of output: 10317

sentences/es/homeassistant_HassIncreaseTimer.yaml (1)

1-15: Improved flexibility for timer increase commands.

The new sentence structures allow for more diverse expressions in increasing timer durations. This should improve user experience by accommodating various speech patterns.

Verification successful

Improved flexibility for timer increase commands.

The new sentence structures allow for more diverse expressions in increasing timer durations. This should improve user experience by accommodating various speech patterns.

#!/bin/bash
# Description: Verify integration with other timer-related configurations.

# Test: Check for consistency with other timer intent configurations.
fd 'homeassistant_HassIncreaseTimer.yaml' --exec rg 'timer'

[task review_file_2/4 re-analyze_results_1/1] Re-analyzing the results of the shell script execution.
[observations] The script output contains multiple timer-related sentences in various languages, indicating a broad set of configurations for timer intents.
[decomposition] Compare the new Spanish sentences with existing patterns in other languages to ensure consistency.
[task review_file_2/4 re-analyze_results_1/1 sub-task 1/2] Check for consistency in sentence structures across different languages.
[analysis] The Spanish sentences follow a similar structure to those in other languages, ensuring consistency in intent configurations.
[actions] Conclude the verification process, as the new sentences are consistent with existing configurations.
-->

Improved flexibility for timer increase commands.

The new sentence structures allow for more diverse expressions in increasing timer durations. This should improve user experience by accommodating various speech patterns. The new Spanish sentences are consistent with existing configurations in other languages.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify integration with other timer-related configurations.

# Test: Check for consistency with other timer intent configurations.
fd 'homeassistant_HassIncreaseTimer.yaml' --exec rg 'timer'

Length of output: 6033

tests/es/homeassistant_HassPauseTimer.yaml (1)

1-38: Comprehensive test coverage for pausing timers.

The test scenarios added cover a wide range of typical user commands, ensuring robust testing of the pausing functionality. Confirm that these tests integrate seamlessly with the overall test suite.

Verification successful

Comprehensive test coverage for pausing timers.

The test scenarios added cover a wide range of typical user commands, ensuring robust testing of the pausing functionality. The verification shows that these scenarios are well represented in the homeassistant_HassPauseTimer.yaml file and other related test files in the repository.

  • tests/es/homeassistant_HassPauseTimer.yaml
  • Other relevant test files containing scenarios for pausing timers
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the integration of these tests with the overall test suite.

# Test: Check for any missing test scenarios related to pausing timers.
fd 'homeassistant_HassPauseTimer.yaml' --exec rg 'pausar|parar|detén'

Length of output: 252



Script:

#!/bin/bash
# Description: Search for additional test files or scenarios related to pausing timers.

# Test: Check for any other test files or scenarios related to pausing timers.
fd '.*\.yaml' --exec rg 'pausar|parar|detén'

Length of output: 531

tests/es/homeassistant_HassUnpauseTimer.yaml (1)

1-38: Robust test coverage for unpausing timers.

The test scenarios added ensure thorough testing of the unpause functionality with various user commands. Confirm that these tests integrate seamlessly with the overall test suite.

Verification successful

Robust test coverage for unpausing timers.

The test scenarios added ensure thorough testing of the unpause functionality with various user commands. Confirm that these tests integrate seamlessly with the overall test suite.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the integration of these tests with the overall test suite.

# Test: Check for any missing test scenarios related to unpausing timers.
fd 'homeassistant_HassUnpauseTimer.yaml' --exec rg 'continuar|seguir|reactivar'

Length of output: 297

sentences/es/homeassistant_HassDecreaseTimer.yaml (1)

1-15: Translations and syntax appear correct for timer decrease commands.

The intent definitions and sentences are well-structured and seem to cover a comprehensive range of commands for timer manipulation. The use of placeholders like <timer_duration>, <timer_start>, and {timer_name:name} is consistent and clear.

tests/es/homeassistant_HassCancelTimer.yaml (1)

1-41: Comprehensive test coverage for timer cancellation.

The test cases provided cover a variety of scenarios including basic cancellation, cancellation by duration, by name, and by area. This should ensure robust behavior in diverse situations. The syntax and structure are correct, and the responses are consistent.

sentences/es/homeassistant_HassTimerStatus.yaml (1)

1-14: Well-structured and clear intent definitions for timer status queries.

The sentences cover a broad spectrum of queries regarding the status and remaining time of timers, including queries by name and area. The syntax is correct and the placeholders are used appropriately, ensuring flexibility in user commands.
[APROVED]

tests/es/media_player_HassMediaNext.yaml (1)

Line range hint 1-44: Diverse and relevant test cases for media track skipping.

The test cases are well-structured, providing scenarios for skipping media tracks on different devices and in different areas. The use of slots and context is appropriate, ensuring the tests are relevant to the intended functionality. The response "Reproduciendo siguiente" is consistently used, which is good for uniformity.

sentences/es/light_HassTurnOn.yaml (1)

5-10: LGTM!

This addition enhances the Spanish language support for light control, making the interface more user-friendly for Spanish speakers.

tests/es/media_player_HassSetVolume.yaml (1)

4-16: Well-crafted test cases!

These test cases are comprehensive and cover various user inputs for setting volume, which enhances the robustness of the voice control feature.

tests/es/homeassistant_HassTimerStatus.yaml (1)

1-48: Comprehensive test coverage for timer status!

The test cases added provide detailed and specific feedback for various timer scenarios, significantly enhancing the user experience for Spanish speakers.

tests/es/homeassistant_HassDecreaseTimer.yaml (1)

1-49: Excellent test cases for decreasing timer durations!

These tests are well-structured and ensure that the timer decrease functionality is robust and behaves as expected in various scenarios.

tests/es/homeassistant_HassIncreaseTimer.yaml (1)

1-50: Comprehensive and well-structured test cases for increasing timer duration.

The test cases are well-formed and cover a variety of scenarios, including adding minutes to timers with specific names and in specific areas such as "Cocina". This should adequately test the functionality of the HassIncreaseTimer intent.

sentences/es/cover_HassGetState.yaml (1)

Line range hint 1-40: Enhanced flexibility in querying cover states.

The modifications in the sentences allow for more flexible queries regarding the state of covers, accommodating user inputs about specific areas and floors. This should improve the user experience by making the interactions more natural and context-aware.

tests/es/homeassistant_HassStartTimer.yaml (1)

1-121: Comprehensive test scenarios for starting timers.

The test cases cover a broad range of scenarios, from simple timers to more complex ones involving hours, minutes, and seconds. This thorough testing ensures that the HassStartTimer intent handles a variety of user inputs effectively.

tests/es/cover_HassGetState.yaml (1)

Line range hint 1-135: Detailed and context-aware test cases for cover state queries.

The test cases are well-constructed and provide a detailed examination of the HassGetState intent's functionality in different contexts. This ensures robust testing of the intent's ability to handle queries about the state of covers in various scenarios.

responses/es/HassTimerStatus.yaml (1)

47-47: Remove trailing spaces on line 47.

Trailing spaces can lead to unnecessary git changes and may affect the readability or functionality in some contexts.

-            Al temporizador
+            Al temporizador

Likely invalid or redundant comment.

Tools
yamllint

[error] 47-47: trailing spaces (trailing-spaces)

sentences/es/_common.yaml (1)

484-500: Verify the implementation of timer-related expansion rules.

The expansion rules for timers have been defined, but it's crucial to ensure they integrate correctly with the rest of the system, especially the voice commands and responses.

Verification successful

Timer-related expansion rules are correctly implemented and consistently used across the codebase.

  • The sentences/es/_common.yaml file defines timer-related rules in a manner consistent with other language files.
  • The rules are integrated with voice commands and responses, as seen in the search results across multiple files.
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify timer-related expansion rules are correctly implemented.

# Test: Search for usage of timer-related rules in the codebase. Expect: Consistent usage across all files.
rg --type yaml $'timer_set|timer_cancel|timer_duration'

Length of output: 31877


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@davefx davefx changed the title Updating Spanish translations to 2024.6.21 [ES] Updating Spanish translations to 2024.6.21 Jun 24, 2024
@davefx davefx enabled auto-merge (squash) June 24, 2024 05:02
@davefx davefx merged commit 2406897 into home-assistant:main Jun 24, 2024
2 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

{% elif (next_timer.start_seconds > 0): %}
{{ next_timer.start_seconds }} segundo{{ "s" if next_timer.start_seconds != 1 }}
{% endif %}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing spaces on line 68.

Trailing spaces here can lead to similar issues as noted above, maintaining clean code is essential for future maintenance.

-            
+
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Tools
yamllint

[error] 68-68: trailing spaces (trailing-spaces)

@@ -44,34 +53,43 @@ entities:

- name: Interruptor dormitorio
id: switch.interruptor_dormitorio
area: dormitorio
area: id_dormitorio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typographical error in entity state value.

The state value for "Interruptor dormitorio" is misspelled as "apadado" instead of "apagado".

-    state:
-      in: "apadado"
-      out: "off"
+    state:
+      in: "apagado"
+      out: "off"

Committable suggestion was skipped due to low confidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant