Add HassGetDate and HassGetTime #2300

synesthesiam · 2024-07-10T18:53:07Z

Add English sentences for two new intents (not yet supported in HA):

HassGetCurrentDate
- Receives a date slot value with a datetime object
- Responds with the current date
HassGetCurrentTime
- Receives a time slot value with a datetime object
- Responds with the current time

Note that strftime should not be used since it will use the machine's current locale and not the intent's language.

coderabbitai · 2024-07-10T18:53:18Z

Walkthrough

The update introduces new intents, HassGetCurrentDate and HassGetCurrentTime, to retrieve the current date and time, respectively. It includes changes across various files to support these intents, adds response templates, and integrates validation and testing for natural language queries related to date and time.

Changes

File(s)	Summary
`intents.yaml`	Added intents `HassGetCurrentDate` and `HassGetCurrentTime` with descriptions.
`responses/en/HassGetCurrentDate.yaml`, `responses/en/HassGetCurrentTime.yaml`	Introduced response templates for new intents in English.
`script/intentfest/generate_day_ordinals.py`	Added functionality to generate day ordinals mapped to words.
`script/intentfest/util.py`	Included `generate_day_ordinals` in the accepted commands list.
`script/intentfest/validate.py`	Added initialization of date and time slots using `datetime.now()` for validation.
`sentences/en/homeassistant_HassGetCurrentDate.yaml`, `sentences/en/homeassistant_HassGetCurrentTime.yaml`	Introduced intents in English for obtaining the current date and time.
`shared/__init__.py`	Imported `datetime` and initialized `_TEST_DATETIME`, setting it for date/time slots.
`tests/en/homeassistant_HassGetCurrentDate.yaml`, `tests/en/homeassistant_HassGetCurrentTime.yaml`	Added test cases for querying the current date and time in natural language.

Sequence Diagram(s)

Silently ignored generating this section as the changes do not significantly alter control flows or add complex new features.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 45b591c and 5f22cb6.

Files selected for processing (7)

intents.yaml (1 hunks)
responses/en/HassGetCurrentDate.yaml (1 hunks)
responses/en/HassGetCurrentTime.yaml (1 hunks)
sentences/en/homeassistant_HassGetCurrentDate.yaml (1 hunks)
sentences/en/homeassistant_HassGetCurrentTime.yaml (1 hunks)
tests/en/homeassistant_HassGetCurrentDate.yaml (1 hunks)
tests/en/homeassistant_HassGetCurrentTime.yaml (1 hunks)

Files skipped from review due to trivial changes (6)

responses/en/HassGetCurrentDate.yaml
responses/en/HassGetCurrentTime.yaml
sentences/en/homeassistant_HassGetCurrentDate.yaml
sentences/en/homeassistant_HassGetCurrentTime.yaml
tests/en/homeassistant_HassGetCurrentDate.yaml
tests/en/homeassistant_HassGetCurrentTime.yaml

Files skipped from review as they are similar to previous changes (1)

intents.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

script/intentfest/generate_day_ordinals.py (1)
1-1: Add module-level docstring.

Provide more detailed information about the purpose and usage of this script.
- """Generate a map for day numbers to ordinal words."""
+ """Generate a map for day numbers to ordinal words.

This script generates a JSON map of day numbers to their corresponding ordinal words in a specified language.
Usage: python generate_day_ordinals.py --language <language_code>
"""

frenck · 2024-07-10T19:07:46Z

intents.yaml

+HassGetDate:
+  supported: true
+  domain: homeassistant
+  description: "Gets the current date"
+
+HassGetTime:
+  supported: true
+  domain: homeassistant
+  description: "Gets the current time"


Considering Home Assistant also has date & time entities, these names seem very unfortunate for the future.

Wouldn't it be better to use HassGetCurrentDate and HassGetCurrentTime instead?

That's a good point. I'll change them 👍

home-assistant · 2024-07-10T19:07:50Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

frenck

Nice! 🎉

../Frenck

Add HassGetDate and HassGetTime

45b591c

synesthesiam requested a review from tetele as a code owner July 10, 2024 18:53

home-assistant bot added cla-signed lang: en labels Jul 10, 2024

coderabbitai bot reviewed Jul 10, 2024

View reviewed changes

frenck requested changes Jul 10, 2024

View reviewed changes

home-assistant bot marked this pull request as draft July 10, 2024 19:07

Rename intents

5f22cb6

synesthesiam marked this pull request as ready for review July 10, 2024 19:13

home-assistant bot requested a review from frenck July 10, 2024 19:13

frenck approved these changes Jul 10, 2024

View reviewed changes

frenck merged commit 698fc4e into main Jul 10, 2024
2 checks passed

frenck deleted the synesthesiam-20240710-datetime-intents branch July 10, 2024 19:21

synesthesiam mentioned this pull request Jul 10, 2024

Add HassGetCurrentDate and HassGetCurrentTime intents home-assistant/core#121707

Merged

19 tasks

tetele mentioned this pull request Aug 1, 2024

[RO] HassGetCurrentDate and HassGetCurrentTime #2361

Merged

mitrokun mentioned this pull request Aug 5, 2024

[RU] Add HassGetCurrentDate #2370

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add HassGetDate and HassGetTime #2300

Add HassGetDate and HassGetTime #2300

synesthesiam commented Jul 10, 2024 •

edited

Loading

coderabbitai bot commented Jul 10, 2024 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

frenck Jul 10, 2024

synesthesiam Jul 10, 2024

synesthesiam Jul 10, 2024

home-assistant bot commented Jul 10, 2024

frenck left a comment

Add HassGetDate and HassGetTime #2300

Add HassGetDate and HassGetTime #2300

Conversation

synesthesiam commented Jul 10, 2024 • edited Loading

coderabbitai bot commented Jul 10, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

frenck Jul 10, 2024

Choose a reason for hiding this comment

synesthesiam Jul 10, 2024

Choose a reason for hiding this comment

synesthesiam Jul 10, 2024

Choose a reason for hiding this comment

home-assistant bot commented Jul 10, 2024

frenck left a comment

Choose a reason for hiding this comment

synesthesiam commented Jul 10, 2024 •

edited

Loading

coderabbitai bot commented Jul 10, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)