Fix file_name_template to produce the same binary names #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
approved these changes
Mar 16, 2023
|
There is now a dot before the arm versions which I don't think is supposed to be there, e.g.: os-agent_1.5.1_linux_**.**armv5.deb |
|
Interesting. I don't really see where that comes from, but it must be related to this change: https://github.com/home-assistant/os-agent/pull/136/files. |
|
This change seems to fix the problem: #137 I've manually renamed the affected deb packages in the 1.5.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the nfpms.replacements example is not based on a default configuration. The example causes ARM binaries to be named differently.
Use default
file_name_templateas base and implement our replacements based on that.