Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Merge New Types for WaterQuality #1000

Closed
wants to merge 3 commits into from

Conversation

waltmoorhouse
Copy link

♻️ Current situation

Water Quality Sensors are not supported

💡 Proposed solution

Add a Service and Characteristics to allow Water Quality Sensors to be supported.

⚙️ Release Notes

New Types added. No breaking changes.

➕ Additional Information

Testing

Reviewer Nudging

Create a new WaterQualityService and add the new Characteristics to it.

@Supereg
Copy link
Member

Supereg commented Apr 20, 2023

When was this service introduced? Are they documented anywhere?
The files the PR changes are auto generated normally. The sources from which we auto generate those files don't include the updated service.
Otherwise, the generator tool also includes the ability to manually define these inputs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4572154496

  • 36 of 61 (59.02%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 64.957%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/definitions/CharacteristicDefinitions.ts 32 44 72.73%
src/lib/definitions/ServiceDefinitions.ts 4 17 23.53%
Totals Coverage Status
Change from base Build 3709412126: -0.09%
Covered Lines: 7432
Relevant Lines: 10650

💛 - Coveralls

@donavanbecker
Copy link
Contributor

going to close this PR as there hasn't been any movement for over a year. If you would like to provide documentation as @Supereg requested then we can revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants