provide connection source address hint to advise udp binding #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this fairly minor but effective PR is dangling for a month because two (deprecated node v14 and v16) checks are blocking the merging? Can someone manually merge please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently HAP-NodeJS doesn't provide the incoming address for the HAP connection. This means that the UDP video must bind to 0.0.0.0, and can be problematic. For example, wifi and ethernet may both be connected to the LAN. Binding to all addresses and sending data may result in the video being sent over wifi.
Currently getting around this by requiring users to select their LAN IP addresses, and guessing which address to use based on ipv4 and ipv6. This doesn't really work if multiple ipv4 addresses are advertised on different networks.
Providing the source address for the connection in addition to the target would be ideal here.