Set ciao as default advertiser #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donavanbecker
force-pushed
the
ciao-default
branch
from
38a613d
to
2a0bd3d
Compare
hjdhjd
reviewed
Jul 20, 2024
| @@ -1186,16 +1186,16 @@ export class Accessory extends EventEmitter { | |||
| // create our Advertiser which broadcasts our presence over mdns | |||
| const parsed = Accessory.parseBindOption(info); | |||
|
|
|||
| let selectedAdvertiser = info.advertiser ?? MDNSAdvertiser.BONJOUR; | |||
| let selectedAdvertiser = info.advertiser ?? MDNSAdvertiser.CIAO; | |||
| if ( | |||
| (info.advertiser === MDNSAdvertiser.AVAHI && !await AvahiAdvertiser.isAvailable()) || | |||
| (info.advertiser === MDNSAdvertiser.RESOLVED && !await ResolvedAdvertiser.isAvailable()) | |||
| ) { | |||
There was a problem hiding this comment.
The test should be against selectedAdvertiser, not the info block, or use the nullish coalescing assignment operator and refactor slightly:
info.advertiser ??= MDNSAdvertiser.CIAO;
Then you can eliminate declaring and using selectedAdvertiser altogether.
donavanbecker
force-pushed
the
ciao-default
branch
from
2a0bd3d
to
178a066
Compare
github-actions
bot
added
the
beta
hjdhjd
approved these changes
Jul 21, 2024
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Bonjour is currently the default advertiser
💡 Proposed solution
Set Ciao as the default advertiser
⚙️ Release Notes
Caio is now the default advertiser