Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18 - Node.js v18 os.networkInterfaces()[].family number/string c… #25

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

oznu
Copy link
Member

@oznu oznu commented Apr 27, 2022

♻️ Current situation

nodejs/node#42787
nodejs/node#41431 (comment)

💡 Proposed solution

It's worth doing this sooner rather than later. There may be other compatibility issues in Node.js 18 we won't find until this one is patched.

The use of @ts-expect-error should alert us to remove the exception when @types/node is updated to 18 (if they decide to keep backwards compatibility with old versions, which they may not, be we need to).

Alternatively we could do something like this, but I feel like it will result in the exception never being removed in the future:

(info.family === "IPv6" || (info.family as unknown as string) === 6)

⚙️ Release Notes

  • Fix an issue with network interface family detection when running Node.js 18

Reviewer Nudging

@Supereg

@oznu oznu requested a review from Supereg April 27, 2022 01:04
@github-actions github-actions bot added the fix label Apr 27, 2022
@coveralls
Copy link

coveralls commented Apr 27, 2022

Pull Request Test Coverage Report for Build 2230313822

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 35.733%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/NetworkManager.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 1491628923: -0.04%
Covered Lines: 1200
Relevant Lines: 3047

💛 - Coveralls

@donavanbecker donavanbecker enabled auto-merge (squash) April 27, 2022 04:57
@oznu oznu disabled auto-merge April 27, 2022 09:13
@oznu oznu merged commit 12cd92c into master Apr 27, 2022
@oznu oznu deleted the beta-1.1.4 branch April 27, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants