Fix #18 - Node.js v18 os.networkInterfaces()[].family number/string c… #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
nodejs/node#42787
nodejs/node#41431 (comment)
💡 Proposed solution
It's worth doing this sooner rather than later. There may be other compatibility issues in Node.js 18 we won't find until this one is patched.
The use of
@ts-expect-error
should alert us to remove the exception when @types/node is updated to 18 (if they decide to keep backwards compatibility with old versions, which they may not, be we need to).Alternatively we could do something like this, but I feel like it will result in the exception never being removed in the future:
⚙️ Release Notes
Reviewer Nudging
@Supereg