Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "latestReleaseDate" property to HomebrigePlugin #336

Merged
merged 4 commits into from
Jul 23, 2019

Conversation

mediter
Copy link
Contributor

@mediter mediter commented Jul 15, 2019

When a search returns multiple similar looking plugins, display the
latestReleaseDate might help people choose which plugin to use

add *ngIf="!plugin.installedVersion" to latestReleaseDate in ui

Known Issue
Currently, latestReleaseDate would also be shown for installed plugins, but package.json of installed plugins doesn't have "date" property

Ideally we could fetch this from npmjs.com registry, the response json has "date" property for each plugin

When a search returns multiple similar looking plugins, display the
latestReleaseDate might help people choose which plugin to use

add package-lock.json for server side and ui because this file is auto-generated
by npm, thus no need to include it in version control
unignore npm lock files

add *ngIf="!plugin.installedVersion" to latestReleaseDate in ui
@oznu
Copy link
Member

oznu commented Jul 16, 2019

Thanks for the PR.

Are you able to update the plugin.service.ts file to only include the relevant changes - not the formatting updates?

in file 'src/modules/plugins/plugins.service.ts'

move label 'Latest Release Date:' inside {{}} so that *ngIf can control
when to show this label
@mediter
Copy link
Contributor Author

mediter commented Jul 17, 2019

Would this be okay? The reformatting might have been caused by a vscode extension. But I have disabled format on save, yet the editor still reformats the code on save. Quite odd.

@oznu
Copy link
Member

oznu commented Jul 17, 2019

Looking good now. Thanks.

I'll merge this soon.

add '"editor.formatOnSave": true' to '.vscode/settings.json'
this file seems to be auto-generated
@oznu oznu merged commit 137a8b3 into homebridge:master Jul 23, 2019
@oznu
Copy link
Member

oznu commented Jul 23, 2019

I adjusted the display of this:

image

@oznu
Copy link
Member

oznu commented Jul 23, 2019

This is currently in beta, and will be release as part of v4.6.0.

You can install the beta now by running:

sudo npm install -g --unsafe-perm homebridge-config-ui-x@next

@mediter
Copy link
Contributor Author

mediter commented Jul 28, 2019

Thank you!

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants