-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow omitting whitespace only changes #222
Comments
Thanks for reaching out. So just that I do not misunderstand it, that would be similar to the GitHub compare feature where you can leave out whitespace changes from the diff to concentrate on the actual changes? Yes, that would make perfect sense. |
Yeah, that's what I was thinking. Currently dyff already identiifes the "whitespace only change" but then still always inlines those changes anyway. Would be good to focus on the important diff. |
I am currently slow to respond in my projects here, but I will definitely have a look. |
I'm hitting on this currently, are you accepting PR's for this? @aoktox's change looks good but no pr is opened against this project, I can create my own if abandoned |
+1, would love to see this as well! |
Fixes: #222 Introduce flag to ignore leading and trailing whitespaces in strings.
Thank you everyone for your patience with this feature. It will be included in the next release. The flag is kind of a bit ironic, because one of the core reasons for this tool in the beginning was to detect trailing whitespaces in BOSH manifests. So in honor of BOSH manifests and for the sake of being backwards compatible, the default behavior will still be to show whitespace only changes. |
Hey all, thanks a lot for maintaining this great tool!
This is a feature request/suggestion for
isWhitespaceOnlyChange
s:dyff/pkg/dyff/output_human.go
Lines 337 to 342 in 416d58b
It would be amazing to have a
--omit-whitespace
flag ondyff between
.WDYT?
The text was updated successfully, but these errors were encountered: