Skip to content

Commit

Permalink
feat: changes default revision from master to main
Browse files Browse the repository at this point in the history
Closes: #948
  • Loading branch information
subzero10 committed Nov 18, 2022
1 parent 523af4a commit 83e1b5f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions packages/webpack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ These plugin parameters correspond to the Honeybadger [Source Map Upload API](ht
sourcemap server you would like to upload your sourcemaps to instead
of honeybadger.</dd>

<dt><code>revision</code> (optional &mdash; default: "master")</dt>
<dt><code>revision</code> (optional &mdash; default: "main")</dt>
<dd>The deploy revision (i.e. commit hash) that your source map applies to. This could also be a code version. For best results, set it to something unique every time your code changes. <a href="https://docs.honeybadger.io/lib/javascript/guides/using-source-maps.html#versioning-your-project">See the Honeybadger docs for examples.</a></dd>

<dt><code>silent</code> (optional &mdash; default: "null/false")</dt>
Expand Down Expand Up @@ -85,7 +85,7 @@ const webpackConfig = {
plugins: [new HoneybadgerSourceMapPlugin({
apiKey: 'abc123',
assetsUrl: ASSETS_URL,
revision: 'master',
revision: 'main',
// You can also enable deployment notifications:
deploy: {
environment: process.env.NODE_ENV,
Expand All @@ -103,7 +103,7 @@ const HoneybadgerSourceMapPlugin = require('@honeybadger-io/webpack')

// Assumes Heroku / 12-factor application style ENV variables
// named GIT_COMMIT, HONEYBADGER_API_KEY, ASSETS_URL
const revision = process.env.GIT_COMMIT || 'master'
const revision = process.env.GIT_COMMIT || 'main'

environment.plugins.append(
'HoneybadgerSourceMap',
Expand Down
2 changes: 1 addition & 1 deletion packages/webpack/src/HoneybadgerSourceMapPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class HoneybadgerSourceMapPlugin {
apiKey,
assetsUrl,
endpoint = ENDPOINT,
revision = 'master',
revision = 'main',
silent = false,
ignoreErrors = false,
retries = 3,
Expand Down
4 changes: 2 additions & 2 deletions packages/webpack/test/HoneybadgerSourceMapPlugin.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ describe(PLUGIN_NAME, function () {
expect(this.plugin).to.include({ silent: false })
})

it('should default revision to "master"', function () {
expect(this.plugin).to.include({ revision: 'master' })
it('should default revision to "main"', function () {
expect(this.plugin).to.include({ revision: 'main' })
})

it('should default retries to 3', function () {
Expand Down

0 comments on commit 83e1b5f

Please sign in to comment.