Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v5 #959

Merged
merged 6 commits into from
Feb 5, 2023
Merged

Release v5 #959

merged 6 commits into from
Feb 5, 2023

Conversation

subzero10
Copy link
Member

@subzero10 subzero10 commented Nov 25, 2022 •
edited
Loading

Status

READY

Description

Closes #961 .
Closes #992 (original PR here).

Notes:

  • PR title check will fail because the title is not CC syntax. It's OK, for this PR we will not squash -> we want the separate commits.
  • Do not SQUASH when merging!

@subzero10 subzero10 added this to the v5 milestone Nov 25, 2022
@subzero10 subzero10 self-assigned this Nov 25, 2022
This was referenced Nov 25, 2022
Merged
Merged
stympy
stympy previously approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@stympy stympy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good... will the changelog be updated separately?

@subzero10
Copy link
Member Author

It looks good... will the changelog be updated separately?

Versioning and changelog generation are done automatically with the help of lerna and conventional commits!

@subzero10 subzero10 requested a review from stympy February 3, 2023 10:05
@subzero10
Copy link
Member Author

Thank you @BethanyBerkowitz!

I think we are ready to release v5!
I will go ahead with your approval @stympy @BethanyBerkowitz.

BethanyBerkowitz
BethanyBerkowitz approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@BethanyBerkowitz BethanyBerkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@subzero10 subzero10 merged commit 4d1efc3 into master Feb 5, 2023
@subzero10 subzero10 added webpack @honeybadger-io/webpack js @honeybadger-io/js rollup/vite @honeybadger-io/rollup-plugin labels Mar 1, 2023
@BethanyBerkowitz BethanyBerkowitz deleted the releases/v5 branch May 15, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyBerkowitz BethanyBerkowitz BethanyBerkowitz approved these changes

@shalvah shalvah Awaiting requested review from shalvah

@stympy stympy Awaiting requested review from stympy

Assignees

@subzero10 subzero10

Labels
js @honeybadger-io/js rollup/vite @honeybadger-io/rollup-plugin webpack @honeybadger-io/webpack
Projects
None yet
Milestone
v5
Development

Successfully merging this pull request may close these issues.

Vite Plugin for Source Maps Add "engines" property in package.json
3 participants
@subzero10 @stympy @BethanyBerkowitz