fix: don't run middleware in Sinatra when not configured #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadast
force-pushed
the
tt/lazy-middleware
branch
from
e79f7d1 to
0803230
Compare
tadast
changed the title
tadast
changed the title
tadast
force-pushed
the
tt/lazy-middleware
branch
from
0803230 to
b58de71
Compare
tadast
changed the title
|
Not sure why the tests are failing, they're failing for me on master too... |
@tadast thanks for this. I've updated master to fix those broken tests. If you are able, could you merge in the latest changes from our master branch into yours? Once the tests pass we can merge this in. |
While honeybadger-io#549 has removed middleware loading for Rails unless configured, it has also removed the code that prevented the middleware from executing unless configured. A similar change is also required for Sinatra, because currently it tries to execute when not configured. When a Sinatra app does not use i18n gem and has user feedback disabled, it errs with a "I18n::InvalidLocale - :en is not a valid locale" exception from ERB, because Honeybadger tries to render the feedback form.
tadast
force-pushed
the
tt/lazy-middleware
branch
from
b58de71 to
e5e1ef3
Compare
|
Nice one, looking green now @roelbondoc |
roelbondoc
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #549 has removed middleware loading for Rails unless configured, it has also removed the code that prevented the middleware from executing in other frameworks unless configured i.e.
return @app.call(env) unless config[:FLAG].A similar change to rails initializer in #549 is now also required for Sinatra (perhaps the same for Hanami?), because currently it loads and executes the feedback and user informer middleware even when they are not configured.