perf: don't insert middleware at all if they've been disabled #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleypriest
changed the title
|
I approved this before I saw that the tests were failing, but once the tests pass, I think this is ready to go. :) |
|
I had a bit of a play around and it looks like the Agent and Config should be instantiated at this point |
tadast
added a commit
to tadast/honeybadger-ruby
that referenced
this pull request
Nov 4, 2024
While honeybadger-io#549 has removed middleware loading for Rails unless configured, it has also removed the code that prevented the middleware from executing unless configured. A similar change is also required for Sinatra, because currently it tries to execute when not configured. When a Sinatra app does not use i18n gem and has user feedback disabled, it errs with a "I18n::InvalidLocale - :en is not a valid locale" exception from ERB, because Honeybadger tries to render the feedback form.
tadast
added a commit
to tadast/honeybadger-ruby
that referenced
this pull request
Nov 4, 2024
While honeybadger-io#549 has removed middleware loading for Rails unless configured, it has also removed the code that prevented the middleware from executing unless configured. A similar change is also required for Sinatra, because currently it tries to execute when not configured. When a Sinatra app does not use i18n gem and has user feedback disabled, it errs with a "I18n::InvalidLocale - :en is not a valid locale" exception from ERB, because Honeybadger tries to render the feedback form.
tadast
added a commit
to tadast/honeybadger-ruby
that referenced
this pull request
Nov 4, 2024
While honeybadger-io#549 has removed middleware loading for Rails unless configured, it has also removed the code that prevented the middleware from executing unless configured. A similar change is also required for Sinatra, because currently it tries to execute when not configured. When a Sinatra app does not use i18n gem and has user feedback disabled, it errs with a "I18n::InvalidLocale - :en is not a valid locale" exception from ERB, because Honeybadger tries to render the feedback form.
tadast
added a commit
to tadast/honeybadger-ruby
that referenced
this pull request
Nov 5, 2024
While honeybadger-io#549 has removed middleware loading for Rails unless configured, it has also removed the code that prevented the middleware from executing unless configured. A similar change is also required for Sinatra, because currently it tries to execute when not configured. When a Sinatra app does not use i18n gem and has user feedback disabled, it errs with a "I18n::InvalidLocale - :en is not a valid locale" exception from ERB, because Honeybadger tries to render the feedback form.
roelbondoc
pushed a commit
that referenced
this pull request
Nov 5, 2024
While #549 has removed middleware loading for Rails unless configured, it has also removed the code that prevented the middleware from executing unless configured. A similar change is also required for Sinatra, because currently it tries to execute when not configured. When a Sinatra app does not use i18n gem and has user feedback disabled, it errs with a "I18n::InvalidLocale - :en is not a valid locale" exception from ERB, because Honeybadger tries to render the feedback form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on my comment from 7 years ago.
ab2c8cb#r22137232
If I've disabled the middlewares I would like to not see them in
rails middleware