Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit an event for karafka stats #637

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

roelbondoc
Copy link
Member

This sends an event when Karafka emits a statistics_emitted event. It can be toggled off with the following configuration:

karafka:
  insights:
    events: false

All metrics in the karafka plugin should now be disabled by default and will need to be enabled by:

karafka:
  insights:
    metrics: true

(actually this was already the case, but I missed one metric, so now all metrics are disabled)

Before submitting a pull request, please make sure the following is done:

  1. If you've fixed a bug or added code that should be tested, add tests!
  2. Run rake spec in the repository root.
  3. Use a pull request title that conforms to conventional commits.

This sends an event when Karafka emits a `statistics_emitted` event. It
can be toggled off with the following configuration:

```
karafka:
  insights:
    events: false
```

All metrics in the karafka plugin should now be disabled by default and
will need to be enabled by:
```
karafka:
  insights:
    metrics: true
```

(actually this was already the case, but I missed one metric, so now all metrics are disabled)
@roelbondoc roelbondoc requested a review from a team November 12, 2024 19:49
@roelbondoc roelbondoc merged commit e7e74b5 into master Nov 14, 2024
59 checks passed
@roelbondoc roelbondoc deleted the karafka-stats-event branch November 14, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants