Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validate-pr-title): use PRT not PR #18

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix(validate-pr-title): use PRT not PR #18

merged 1 commit into from
Dec 13, 2023

Conversation

lizthegrey
Copy link
Member

@lizthegrey lizthegrey commented Dec 11, 2023

Which problem is this PR solving?

  • Private repos cannot be monitored by the semantic convention enforcer

Short description of the changes

See amannn/action-semantic-pull-request#173 (comment)

however, this by itself isn't enough as per honeycombio/loadgen#27 - permissions may also need to explicitly be granted.

@lizthegrey lizthegrey requested a review from a team December 11, 2023 06:59
@MikeGoldsmith
Copy link
Collaborator

@lizthegrey this is failing validation - could this be we need to add explicit read permission like in the comment you reference or something else?

@MikeGoldsmith MikeGoldsmith self-assigned this Dec 12, 2023
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think this is necessary for PRs and issues from non-write collaborators.
Liz may not have write permissions which is why her PR is failing, whereas mine passed on #30.
I'm noticing we use pull_request_target on labels and add-to-project so this should probabaly be the same?

@JamieDanielson
Copy link
Contributor

Actually I've totally confused things. The failing check is indeed for a different workflow already using pull_request_target. I have given Liz updated permissions here though, curious if maybe this could be closed and reopened if it would pass? I tried rerunning failed workflow but it didn't work.

@MikeGoldsmith
Copy link
Collaborator

Didn't seem to help 🤷🏻

@lizthegrey
Copy link
Member Author

You have to actually land the change to see the effects. GHA uses the workflows from main when evaluating PR events, not the draft workflow.

@MikeGoldsmith
Copy link
Collaborator

Okay, we'll give it a try. If it doesn't work, we can always roll-back 😄

@MikeGoldsmith MikeGoldsmith merged commit 8a32627 into main Dec 13, 2023
0 of 2 checks passed
@MikeGoldsmith MikeGoldsmith deleted the lizf.fix-prt branch December 13, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants