Update handler to produce a full trace with child spans #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the default recipe to provide a lot more detail in the Signed-off-by: Davin Taddeo <davin@davintaddeo.com>
…hef Client version 17. Signed-off-by: Davin Taddeo <davin@honeycomb.io>
Signed-off-by: Davin Taddeo <davin@honeycomb.io>
…e obviously examples. Signed-off-by: Davin Taddeo <davin@honeycomb.io>
|
As a note. I've only tested this with Chef/CINC client version 17.10 so far. |
pkanal
added
the
status: oncall
tdarwin
added
status: review needed
vreynolds
added
the
status: oncall
MikeGoldsmith
requested changes
Sep 6, 2022
There was a problem hiding this comment.
Looks really good, thanks @tdarwin 👍🏻
I've left some feedback to remove an unused func, remove commented out code and styling things.
MikeGoldsmith
added
type: enhancement
status: revision needed
|
@MikeGoldsmith Thanks for all the suggestions and tweaks and nit-picks. I'll put out another commit soon to clean stuff up. might not be until Friday when I'm back from this conference. |
Signed-off-by: Davin Taddeo <davin@honeycomb.io>
MikeGoldsmith
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The current version of the handler does not produce what Honeycomb recognizes as a trace, so there is no waterfall view of processes, access to use the node object in queries, and very minimal bubble up capabilities.
Short description of the changes
This updates the product to be a full trace, where the compile, converge, and handler phases are all shown as child spans, and the converge phase is broken down into spans per cookbook, recipe, and resource.
All objects have access to a subset of the node object that make bubble-up and querying more interesting, and users are provided with a mechanism to ensure that node attributes/objects that they care about can be included in that data as well.
Notes
There's some funky code to make this work as a handler that's part of a cookbook, but it does. If I were committing this as something I wanted to be part of Chef itself, there would be cleaner ways to do certain things.
Resulting Images
Here are some screen captures of this handler in action in waterfall mode, query + heatmap, and bubble-up:
