feat: add spotless config #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaHaddara
force-pushed
the
mh/spotless
branch
from
6846779 to
7251da5
Compare
MustafaHaddara
force-pushed
the
mh/spotless
branch
from
a13d88b to
87337e7
Compare
beekhc
approved these changes
Oct 30, 2024
| @@ -56,7 +56,8 @@ private const val OTEL_EXPORTER_OTLP_LOGS_PROTOCOL_KEY = "OTEL_EXPORTER_OTLP_LOG | |||
| enum class OtlpProtocol { | |||
| GRPC, | |||
| HTTP_PROTOBUF, | |||
| HTTP_JSON; | |||
| HTTP_JSON, | |||
| ; | |||
There was a problem hiding this comment.
lol, that's a weird one. fine, but weird
| @@ -159,21 +159,17 @@ data class HoneycombOptions( | |||
| val logsEndpoint: String, | |||
| val sampleRate: Int, | |||
| val debug: Boolean, | |||
|
|
|||
There was a problem hiding this comment.
well, it's mildly annoying that it removed the grouping. but not worth fighting the linter over
example/build.gradle.kts
Outdated
| @@ -1,7 +1,8 @@ | |||
| plugins { | |||
| alias(libs.plugins.android.application) | |||
| alias(libs.plugins.jetbrains.kotlin.android) | |||
| id("net.bytebuddy.byte-buddy-gradle-plugin") version("1.15.5") | |||
| id("net.bytebuddy.byte-buddy-gradle-plugin") version ("1.15.5") | |||
There was a problem hiding this comment.
should we move this into libs.versions.toml?
MustafaHaddara
force-pushed
the
mh/spotless
branch
from
15ab2db to
44d2e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds
spotlessand its associated config to the projectShort description of the changes
.editorconfigto configure ktlintHow to verify that this has the expected result
./gradlew spotlessCheckgets run in CI. To demonstrate: this commit adds a lint error, and fails the lint step. The next commit fixes the lint error and passes the lint step.