fix: Auto-select the SDK when running smoke tests. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beekhc
changed the title
MustafaHaddara
approved these changes
Nov 19, 2024
Comment on lines
+3
to
+4
| SDK=$(xcodebuild -showsdks | grep iphonesimulator | sed -e 's/^.*-sdk //') | ||
| echo "SDK: $SDK" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently, our smoke tests are hard-coded to a particular SDK we know is available in circleci. But individual developers have updated Xcode and no longer have that version. So, everyone has to edit this file to make the smoke tests run. This PR changes the script to autodetect the SDK version to use.
Short description of the changes
xcodebuild -showsdkslists the SDKs. We filter foriphonesimulator, and then use an ad-hoc regex to get just the name of the SDK.How to verify that this has the expected result
I tested it locally. If it still passes in circleci, it should be good to go.