Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default SendFrequency to 10 seconds #27

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

MikeGoldsmith
Copy link
Contributor

Fixes #16.

Updates the default SendFrequency to 10000ms (10 seconds) to match documentation and default value in example appsettings.json.

@MikeGoldsmith MikeGoldsmith requested a review from a team March 5, 2021 15:55
Copy link
Contributor

@paulosman paulosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling nit - but otherwise lgtm

Co-authored-by: Paul Osman <paul@honeycomb.io>
@MikeGoldsmith MikeGoldsmith changed the title update default SendFrequency to 10 seconds Update default SendFrequency to 10 seconds Mar 8, 2021
@MikeGoldsmith MikeGoldsmith merged commit 477489b into main Mar 8, 2021
@MikeGoldsmith MikeGoldsmith deleted the mike/default_sent_frequency branch March 8, 2021 15:02
MikeGoldsmith added a commit that referenced this pull request Mar 24, 2021
Fixes #16.

Updates the default SendFrequency to 10000ms (10 seconds) to match documentation and default value in example appsettings.json.

Co-authored-by: Paul Osman <paul@honeycomb.io>
MikeGoldsmith added a commit that referenced this pull request Mar 24, 2021
* main:
  Fix typo in project file. (#31)
  Add WriteKey and deprecate TeamId (#30)
  Update default SendFrequency to 10 seconds (#27)
  Stopping the timer before calculating the elapsedmilliseconds (#28)

# Conflicts:
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default SendFrequency is probably wrong
2 participants