Fix authors, move examples and target netstandard2.0 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
version: bump minor
MikeGoldsmith
changed the title
cartermp
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Should we also configure this to build with symbols and be deterministic/signed/etc. like so? https://github.com/honeycombio/honeycomb-opentelemetry-dotnet/blob/main/Directory.build.props
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Honeycomb.Tests", "test\Honeycomb.Tests\Honeycomb.Tests.csproj", "{42710D9F-1438-4C49-84F8-E06A6D19E887}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Sample", "examples\Sample\Sample.csproj", "{253D987E-EA95-4FC6-B347-AA30A5F1FAD9}" |
There was a problem hiding this comment.
Nothing like looking at good 'ole .sln files in code review!
…ke/clean-up * 'main' of github.com:honeycombio/libhoney-dotnet: Bump xunit.runner.visualstudio from 2.4.0 to 2.4.3 (#45)
cartermp
approved these changes
Dec 15, 2021
|
oh it looks like codeowners isn't in here |
JamieDanielson
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Tidies up the repository to fix misspelled nuget package author names, move the sample app into an examples directory and update Honeycomb.AspNet build target to netstandard2.0 among other clean-up tasks.
Short description of the changes
Honeycombof authors in csproj's