Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add key cardinality testing feature #67

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

kentquirk
Copy link
Collaborator

Which problem is this PR solving?

  • We've seen issues where the key cardinality of things being fed to a sampler is longer than the sampler AdjustmentInterval. This gives loadgen the ability to generate fields that will only include all possible values once the generator's sample period has completed.

So mykey=/k50,60 will generate a field called mykey that will have values of cardinality 50, but not all possible values will be used until 60 seconds have passed.

Includes testing and benchmark code, as well as a readme update.

@kentquirk kentquirk requested a review from a team as a code owner September 18, 2024 02:49
@kentquirk kentquirk self-assigned this Sep 18, 2024
@MikeGoldsmith
Copy link
Contributor

@kentquirk what's the status if this change? Is it something we still want to pursue?

@kentquirk
Copy link
Collaborator Author

Yes! I've been running it locally, but I'd like an approval from a team member, please. This was used to mimic some traffic like what we were seeing from customers that breaks the EMA sampler.

@kentquirk kentquirk merged commit c2ce691 into main Oct 22, 2024
6 checks passed
@kentquirk kentquirk deleted the kent.key_card_testing branch October 22, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants