Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update WithExporterProtocol in README.md #54

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

NicholasGWK
Copy link
Contributor

Short description of the changes

It seems like the function was renamed, but not updated in the Readme! I noticed when trying to set it :D.

@NicholasGWK NicholasGWK requested a review from a team July 19, 2023 18:30
@pkanal pkanal added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Jul 19, 2023
@NicholasGWK NicholasGWK changed the title Update README.md docs: Update README.md Jul 19, 2023
@NicholasGWK NicholasGWK changed the title docs: Update README.md docs: Update WithExporterProtocol in README.md Jul 19, 2023
@JamieDanielson JamieDanielson added type: documentation Improvements or additions to documentation version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Jul 19, 2023
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicholasGWK !

@JamieDanielson JamieDanielson merged commit 0b934e0 into honeycombio:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: documentation Improvements or additions to documentation version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants