Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Bump OTel dependencies #84

Merged
merged 5 commits into from
Nov 22, 2023
Merged

maint: Bump OTel dependencies #84

merged 5 commits into from
Nov 22, 2023

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Nov 16, 2023

Which problem is this PR solving?

Bumps OTel dependencies to latest versions. This update includes moving the metrics experimental package into the main sdk package which was a breaking change for many users, and would prevent users of this config library from adopting a newer version.

Also, v1.20 no longer supports go 19 and the minimum version of go is 20. This PR updates the go versions unit tests are run with to remove 19 and add 21.

Short description of the changes

  • Update go.mod to use most recent version of OTel packages (v1.20.0 / v0.43.0)
  • Regenerate go.sum
  • Remove go 19 and add 21 to go runtime tests are run in & set default to 21

How to verify that this has the expected result?

Unit & smoke tests continue to pass and users who want to use v1.20.0 and higher can.

@MikeGoldsmith MikeGoldsmith added version: bump minor A PR that adds behavior, but is backwards-compatible. type: maintenance The necessary chores to keep the dust off. labels Nov 16, 2023
@MikeGoldsmith MikeGoldsmith self-assigned this Nov 16, 2023
@MikeGoldsmith MikeGoldsmith requested a review from a team November 16, 2023 13:56
@JamieDanielson JamieDanielson added the breaking-change Prefer 'version: bump major', but use this for breaking changes that don't bump major. label Nov 21, 2023
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I opened PR #87 against this because it's typically best to upgrade all otel packages together, including both core and contrib. If that looks good feel free to approve and merge it in, then this one is good to go

## Which problem is this PR solving?

- OpenTelemetry Go should typically get updated with both core and
contrib packages

## Short description of the changes

- Update contrib packages to
[v1.21.0/v0.46.0](https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.21.0)
to match the corresponding core packages v1.20.0/v0.43.0

## How to verify that this has the expected result

All tests pass.

This is to be merged into Mike's PR #84 that updates the main go
packages and sets minimum go version to 20.
@MikeGoldsmith MikeGoldsmith merged commit 3ec9d9f into main Nov 22, 2023
6 checks passed
@MikeGoldsmith MikeGoldsmith deleted the mike/bump-otel branch November 22, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Prefer 'version: bump major', but use this for breaking changes that don't bump major. type: maintenance The necessary chores to keep the dust off. version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants