Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give lambda parameters a fixed order #64

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Give lambda parameters a fixed order #64

merged 2 commits into from
Nov 28, 2023

Conversation

RainofTerra
Copy link
Contributor

Which problem is this PR solving?

(I hope)

Short description of the changes

  • I think the problem is here unless I'm mistaken. The order for those parameters has to be fixed or it will flap.

How to verify that this has the expected result

@RainofTerra RainofTerra requested a review from a team as a code owner September 8, 2023 21:29
@martin308
Copy link
Member

Is this good to go? Should we merge it?

jharley
jharley approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jharley jharley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this feel through the proverbial cracks! This seems worth trying

@jharley jharley merged commit b9c9c02 into main Nov 28, 2023
3 checks passed
@jharley jharley deleted the terra.fix_kinesis_flapping branch November 28, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharley jharley jharley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform always re-plans changes when using rds-logs module
3 participants
@RainofTerra @martin308 @jharley