Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cloudwatch-metrics - stream opentelemetry1.0 #70

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: cloudwatch-metrics - stream opentelemetry1.0 #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/cloudwatch-metrics/USAGE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
| <a name="input_name"></a> [name](#input\_name) | A unique name for this CloudWatch Metric Stream. | `string` | `"honeycomb-cloudwatch-metrics"` | no |
| <a name="input_namespace_exclude_filters"></a> [namespace\_exclude\_filters](#input\_namespace\_exclude\_filters) | DEPRECATED: use `include_filters` instead.<br><br>An optional list of CloudWatch Metric namespaces to exclude. If set, we'll only stream metrics that are not in these namespaces.<br>Mutually exclusive with `namespace_include_filters`. | `list(string)` | `[]` | no |
| <a name="input_namespace_include_filters"></a> [namespace\_include\_filters](#input\_namespace\_include\_filters) | DEPRECATED: use `include_filters` instead.<br><br>An optional list of CloudWatch Metric namespaces to include. If set, we'll only stream metrics from these namespaces.<br>Mutually exclusive with `namespace_exclude_filters`. | `list(string)` | `[]` | no |
| <a name="input_output_format"></a> [output\_format](#input\_output\_format) | Output format of metrics. You should probably not modify this value; the default format is supported, but others may not be. | `string` | `"opentelemetry0.7"` | no |
| <a name="input_output_format"></a> [output\_format](#input\_output\_format) | Output format of metrics. You should probably not modify this value; the default format is supported, but others may not be. | `string` | `"opentelemetry1.0"` | no |
| <a name="input_s3_backup_mode"></a> [s3\_backup\_mode](#input\_s3\_backup\_mode) | Should we only backup to S3 data that failed delivery, or all data? | `string` | `"FailedDataOnly"` | no |
| <a name="input_s3_buffer_interval"></a> [s3\_buffer\_interval](#input\_s3\_buffer\_interval) | In seconds. See https://docs.aws.amazon.com/firehose/latest/dev/create-configure.html | `number` | `400` | no |
| <a name="input_s3_buffer_size"></a> [s3\_buffer\_size](#input\_s3\_buffer\_size) | In MiB. See https://docs.aws.amazon.com/firehose/latest/dev/create-configure.html | `number` | `10` | no |
Expand All @@ -57,4 +57,4 @@
|------|-------------|
| <a name="output_cloudwatch_metric_stream_arn"></a> [cloudwatch\_metric\_stream\_arn](#output\_cloudwatch\_metric\_stream\_arn) | n/a |
| <a name="output_cloudwatch_metric_stream_name"></a> [cloudwatch\_metric\_stream\_name](#output\_cloudwatch\_metric\_stream\_name) | n/a |
<!-- END_TF_DOCS -->
<!-- END_TF_DOCS -->
4 changes: 2 additions & 2 deletions modules/cloudwatch-metrics/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,11 @@ variable "s3_backup_mode" {

variable "output_format" {
type = string
default = "opentelemetry0.7"
default = "opentelemetry1.0"
description = "Output format of metrics. You should probably not modify this value; the default format is supported, but others may not be."

validation {
condition = contains(["json", "opentelemetry0.7"], var.output_format)
condition = contains(["json", "opentelemetry0.7", "opentelemetry1.0"], var.output_format)
error_message = "Not an allowed output format."
}
}
Expand Down
Loading