Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel: prepare changelog for release #81

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Dec 19, 2024

Ran make update-changelog as per the release doc

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from a team as a code owner December 19, 2024 19:22
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a newer project for our team and doesn't follow our usual release flow. Can you write some notes in the PR description for what you did? like was this output a result of make update-changelog from releasing doc?

Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also since this is preparing a release, we would usually use rel: as the title prefix

@JamieDanielson JamieDanielson changed the title maint: prepare changelog for release rel: prepare changelog for release Dec 19, 2024
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let it go

@codeboten
Copy link
Contributor Author

Removing the apply project labels workflow as part of this, the workflow has not worked in 6 months in this repo

@codeboten codeboten merged commit 5ebb57a into main Dec 19, 2024
3 of 4 checks passed
@codeboten codeboten deleted the codeboten/update-changelog branch December 19, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants