Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sweepers for test cleanup #446

Closed
jharley opened this issue Feb 29, 2024 · 0 comments · Fixed by #516
Closed

Add Sweepers for test cleanup #446

jharley opened this issue Feb 29, 2024 · 0 comments · Fixed by #516
Assignees
Milestone

Comments

@jharley
Copy link
Collaborator

jharley commented Feb 29, 2024

The test suite is still leaving many things behind after a test run: notably Recipients even after a fully successful run. This gets extra sticky if a test run is unable to clean up (panic, cancelled early) and dangling resources end up causing conflicts on the following test runs.

Implementing Sweepers may help ease the pain here, especially if the entire test suite ends up prefixing resources with test- or test. or some such thing.

@jharley jharley self-assigned this Mar 8, 2024
@jharley jharley added this to the 1.0.0 milestone May 2, 2024
jharley added a commit that referenced this issue Jul 29, 2024
Limit integration test runs with [concurrency
groups](https://docs.github.com/en/actions/using-jobs/using-concurrency).

Not currently using `cancel-in-progress` until
[sweepers](#446)
are implemented and it's confirmed that they can run when receiving a
cancellation signal.
jharley added a commit that referenced this issue Jul 30, 2024
Adds
[Sweepers](https://developer.hashicorp.com/terraform/plugin/testing/acceptance-tests/sweepers)
to the project with an initial sweeper for recipients (which seem to
cause the most test failures/conflicts).

This also attempts to get all recipients named with a `test.` prefix
(`#test.` for Slack recipients) establishing the convention that if a
thing's name starts with `test.` is can be "swept".

- Closes #446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant