Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/board: add SLO support #485

Merged
merged 4 commits into from
Jun 14, 2024
Merged

r/board: add SLO support #485

merged 4 commits into from
Jun 14, 2024

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Jun 13, 2024

Adds support to place SLOs on boards.

Following the board's existing query {} blocks, this adds slo {} and takes an ID.

SLOs on Board are under active development and do not yet have an order but are visually displayed by their creation date. Future releases will support ordered placement.

@jharley jharley added the feature This issue wants to add new functionality. label Jun 13, 2024
@jharley jharley requested a review from a team as a code owner June 13, 2024 21:39
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.98%. Comparing base (92f7561) to head (0757d76).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   82.89%   82.98%   +0.09%     
==========================================
  Files          63       63              
  Lines        4308     4332      +24     
==========================================
+ Hits         3571     3595      +24     
  Misses        576      576              
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jharley added 2 commits June 13, 2024 15:13
This reverts commit 6861deb.
This reverts commit a3ad8d9.
@jharley jharley merged commit f3edeef into main Jun 14, 2024
3 checks passed
@jharley jharley deleted the jharley.slos-on-boards branch June 14, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue wants to add new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants