chore: migrate r/webhook_recipient to Framework #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
- Coverage 76.05% 75.56% -0.49%
==========================================
Files 86 87 +1
Lines 7107 7288 +181
==========================================
+ Hits 5405 5507 +102
- Misses 1368 1429 +61
- Partials 334 352 +18 ☔ View full report in Codecov by Sentry. |
jharley
commented
Nov 14, 2024
| if response.Diagnostics.HasError() && !test.expectError { | ||
| t.Fatalf("got unexpected error: %s", response.Diagnostics) | ||
| } | ||
| assert.Equal(t, |
There was a problem hiding this comment.
snuck in a quick move of these validators to testify
| @@ -17,7 +17,7 @@ resource "honeycombio_webhook_recipient" "prod" { | |||
| The following arguments are supported: | |||
|
|
|||
| * `name` - (Required) The name of the Webhook Integration to create. | |||
| * `secret` - (Required) The secret to include when sending the notification to the webhook. | |||
| * `secret` - (Optional) The secret to include when sending the notification to the webhook. | |||
brookesargent
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates
r/webhook_recipientfrom the Plugin SDKv2 to the Plugin Framework.In the process, also updates
secretto be optional to match the upstream change.