Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switched from yargs-parser to commander #64

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

MathurAditya724
Copy link
Contributor

@MathurAditya724 MathurAditya724 commented Aug 4, 2024

  • Removed yargs-parser
  • Added commander
  • commander enables the new -h option, describing all the options
  • Added a new option for using offline/cached templates

@MathurAditya724
Copy link
Contributor Author

Hello, @ryuapp do you have any suggestions on whether we should add the force options to empty the directory? To close this issue #61

In the current implementation, if the directory is not empty either it will create the dir or will exit the program - https://github.com/honojs/create-hono/blob/main/src/index.ts#L97-L109

@ryuapp
Copy link
Contributor

ryuapp commented Aug 5, 2024

Hello, @ryuapp do you have any suggestions on whether we should add the force options to empty the directory? To close this issue #61

I'm negative for the same reason as the following: #62 (comment)
And I also looked at some create-commands, but none had similar options.

Adding the help command seems like a good idea.

@MathurAditya724
Copy link
Contributor Author

I also had similar findings for the --force option. So should we mark the issue as not planned or invalid and close it?

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Aug 8, 2024

Hi @MathurAditya724

This is great! We can merge this PR despite how we handle #61. Thanks!

@yusukebe yusukebe merged commit 1c91004 into honojs:main Aug 8, 2024
3 checks passed
@MathurAditya724 MathurAditya724 mentioned this pull request Aug 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants