Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor linting changes #71

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

MathurAditya724
Copy link
Contributor

I came across some minor limiting changes while working on the previous PRs.

  • Added node: in front of all the node packages
  • Added type
  • Convert all the strings (where possible) into template literals, to have a more consistent codebase
  • remove unused exports from the test file
  • minor code changes

These don't affect the app anyway, just make the codebase more consistent. These are my opinions but let me know if you don't want these in the codebase, and I will close the PR.

@yusukebe yusukebe changed the title chore: minor linting changes refactor: minor linting changes Sep 4, 2024
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Sep 4, 2024

@MathurAditya724

This is good! Merging. Thank you.

@yusukebe yusukebe merged commit a60067d into honojs:main Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants